Reference issue in all outstanding TODOs (#28, #156, #157, #158)

eksctl-io · Sep 4, 2018 · 8baf89e · 8baf89e
1 parent 64b1e41
commit 8baf89e
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 7 deletions.
diff --git a/pkg/cfn/builder/nodegroup.go b/pkg/cfn/builder/nodegroup.go
@@ -70,8 +70,9 @@ func (n *nodeGroupResourceSet) AddAllResources() error {
 	n.rs.newStringParameter(ParamClusterStackName, "")
 	n.rs.newNumberParameter(ParamNodeGroupID, "")
 
-	// TODO: imporve validation of parameter set overall, probably in another package
-	// TODO: validate custom AMI (check it's present) and instance type
+	// TODO: https://github.com/weaveworks/eksctl/issues/28
+	// - imporve validation of parameter set overall, probably in another package
+	// - validate custom AMI (check it's present) and instance type
 	if n.spec.NodeAMI == "" {
 		n.spec.NodeAMI = regionalAMIs[n.spec.Region]
 	}

diff --git a/pkg/nodebootstrap/assets.go b/pkg/nodebootstrap/assets.go
diff --git a/pkg/nodebootstrap/assets/get_metadata.sh b/pkg/nodebootstrap/assets/get_metadata.sh
@@ -10,7 +10,7 @@ set -o nounset
 # we could use the following, but we still need jq to get region and instance ID:
 # aws --output text --region us-west-2 ec2 describe-tags --filters Name=resource-type,Values=instance Name=resource-id,Values=i-017e37452ee14d8d7 --query "Tags[?Key=='eksctl.cluster.k8s.io/v1alpha1/cluster-name'].Value"
 
-# TODO: experiment with a more static version, we can pass region and cluster name and generate whole `metadata.env` if we wanted to
+# TODO: avoid having to do all this – https://github.com/weaveworks/eksctl/issues/157
 
 instanceInfo="$(curl --silent http://169.254.169.254/latest/dynamic/instance-identity/document)"
 

diff --git a/pkg/nodebootstrap/userdata.go b/pkg/nodebootstrap/userdata.go
@@ -62,10 +62,10 @@ func setKubeletParams(config *cloudconfig.CloudConfig, spec *api.ClusterConfig)
 	if spec.MaxPodsPerNode == 0 {
 		spec.MaxPodsPerNode = maxPodsPerNodeType[spec.NodeType]
 	}
-	// TODO: investigate if we can use componentconfig, or at least switch to kubelet config file
+	// TODO: use componentconfig or kubelet config file – https://github.com/weaveworks/eksctl/issues/156
 	kubeletParams := []string{
 		fmt.Sprintf("MAX_PODS=%d", spec.MaxPodsPerNode),
-		// TODO: this will need to change when we provide options for using different VPCs and CIDRs
+		// TODO: this will need to change when we provide options for using different VPCs and CIDRs – https://github.com/weaveworks/eksctl/issues/158
 		"CLUSTER_DNS=10.100.0.10",
 	}