Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SSH docs #3233

Merged
merged 2 commits into from
Feb 15, 2021
Merged

Update SSH docs #3233

merged 2 commits into from
Feb 15, 2021

Conversation

aclevername
Copy link
Contributor

Description

#3198

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 馃く

  • Backfilled missing tests for code in same general area 馃帀
  • Refactored something and made the world a better place 馃専

@aclevername aclevername added kind/docs User documentation area/docs labels Feb 8, 2021
@aclevername aclevername linked an issue Feb 8, 2021 that may be closed by this pull request
Improve docs around using SSH keys #3198
Closed
@aclevername aclevername force-pushed the ssh-docs branch 2 times, most recently from 5515a5d to 0e530e6 Compare February 8, 2021 17:54
@aclevername aclevername mentioned this pull request Feb 8, 2021
Merged
7 tasks
aclevername
aclevername commented Feb 8, 2021
View reviewed changes
userdocs/src/usage/managing-nodegroups.md
@@ -160,6 +160,35 @@ There are no specific commands in `eksctl`to update the labels of a nodegroup bu
kubectl label nodes -l alpha.eksctl.io/nodegroup-name=ng-1 new-label=foo
```

### SSH Access
Copy link
Contributor Author

@aclevername aclevername Feb 8, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't really have a great place for these docs to live, and I don't really want to add a page for just SSH configuration as its pretty minor. I've put it here for now, open to suggests

@aclevername aclevername force-pushed the ssh-docs branch 3 times, most recently from 149f338 to d3d97b0 Compare February 10, 2021 16:49
@aclevername aclevername marked this pull request as ready for review February 10, 2021 16:49
@aclevername aclevername requested a review from a team February 10, 2021 16:51
@aclevername aclevername force-pushed the ssh-docs branch 2 times, most recently from 7a6e2d2 to e1a2b03 Compare February 10, 2021 17:13
michaelbeaumont
michaelbeaumont approved these changes Feb 12, 2021
View reviewed changes
Copy link
Contributor

@michaelbeaumont michaelbeaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aclevername I shortened the strings further (looks better on the schema page), removed the +optional tags hanging around which don't do anything and rebased!

@aclevername
Copy link
Contributor Author

@aclevername I shortened the strings further (looks better on the schema page), removed the +optional tags hanging around which don't do anything and rebased!

Thanks!

@aclevername aclevername enabled auto-merge (squash) February 15, 2021 10:07
@aclevername aclevername merged commit f7da86f into eksctl-io:main Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelbeaumont michaelbeaumont michaelbeaumont approved these changes

@Callisto13 Callisto13 Callisto13 approved these changes

Assignees
No one assigned
Labels
kind/docs User documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve docs around using SSH keys
3 participants
@aclevername @michaelbeaumont @Callisto13