Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make kind/docs a valid label #3234

Merged
merged 2 commits into from
Feb 9, 2021
Merged

Conversation

aclevername
Copy link
Contributor

Description

Proof we don't respect our docs 😂 , noticed in #3233 that providing the kind/docs label doesn't fix the failing pr-label action

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@michaelbeaumont
Copy link
Contributor

We can change this but the reason for enforcing the labels was to make sure the release-drafter catches all the PRs it should catch (leaving aside the fact that it doesn't 100% work) or you have to explicitly pick skip-release-notes. Since we don't have a docs section in the notes, this means kind/docs are implicitly skipped.

@michaelbeaumont michaelbeaumont added the skip-release-notes Causes PR not to show in release notes label Feb 8, 2021
@aclevername
Copy link
Contributor Author

We can change this but the reason for enforcing the labels was to make sure the release-drafter catches all the PRs it should catch (leaving aside the fact that it doesn't 100% work) or you have to explicitly pick skip-release-notes. Since we don't have a docs section in the notes, this means kind/docs are implicitly skipped.

Ah I see, I think docs are important so having it be a valid label is good, but should it be in the release notes? I'm not sure, it is technically delivering value 🤷

Copy link
Contributor

@michaelbeaumont michaelbeaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They should be left out of the notes in most cases I think, I just wanted to call attention to the fact that the check sort of serves a different purpose then.

@michaelbeaumont michaelbeaumont merged commit 605743d into eksctl-io:main Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-release-notes Causes PR not to show in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants