Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding IAM policies for the EBS CSI driver #652

Merged
merged 4 commits into from
Mar 22, 2019
Merged

Adding IAM policies for the EBS CSI driver #652

merged 4 commits into from
Mar 22, 2019

Conversation

christopherhein
Copy link
Contributor

@christopherhein christopherhein commented Mar 21, 2019 •
edited by errordeveloper
Loading

Signed-off-by: Christopher Hein me@chrishein.com

Description

This adds an attribute that automatically applies the EBS CSI driver IAM policies.

Checklist

  • Code compiles correctly (i.e make build)
  • Added tests that cover your change (if possible)
  • All unit tests passing (i.e. make test)
  • All integration tests passing (i.e. make integration-test)
  • Added/modified documentation as required (such as the README.md, and examples directory)
  • Added yourself to the humans.txt file

@errordeveloper
Copy link
Contributor

See #651 for example of unit tests for a similar feature.

@christopherhein
adding policies to automatically allow the EBS CSI driver to be deployed
a70598a 
Signed-off-by: Christopher Hein <me@chrishein.com>
@christopherhein
Adding unit tests for EBS CSI
3420bfe 
Signed-off-by: Christopher Hein <me@chrishein.com>
@christopherhein christopherhein force-pushed the feature/ebs-csi-policies branch from 727418f to 3420bfe Compare March 22, 2019 00:45
@christopherhein
Copy link
Contributor Author

@errordeveloper added a test

@christopherhein christopherhein mentioned this pull request Mar 22, 2019
Closed
@errordeveloper
Copy link
Contributor

@christopherhein thanks! I've extended the test suite a bit more also. There were a few things missing actually, see a69bf47.

errordeveloper
errordeveloper previously approved these changes Mar 22, 2019
View reviewed changes
Copy link
Contributor

@errordeveloper errordeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢LGTM!

@errordeveloper errordeveloper force-pushed the feature/ebs-csi-policies branch from a69bf47 to 42b63f4 Compare March 22, 2019 11:38
@errordeveloper errordeveloper merged commit 2a1189c into eksctl-io:master Mar 22, 2019
@christopherhein christopherhein deleted the feature/ebs-csi-policies branch March 22, 2019 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@errordeveloper errordeveloper errordeveloper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christopherhein @errordeveloper