Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for pod identity associations feature #7313

Merged
merged 9 commits into from
Nov 27, 2023

Conversation

TiberiuGC
Copy link
Collaborator

@TiberiuGC TiberiuGC commented Nov 27, 2023

Description

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@TiberiuGC TiberiuGC added kind/docs User documentation area/docs labels Nov 27, 2023
@TiberiuGC TiberiuGC force-pushed the pod-identity-assocition-docs branch 2 times, most recently from 8fa2a27 to 2e0ce94 Compare November 27, 2023 06:30
@TiberiuGC TiberiuGC changed the base branch from main to podidentityassociation-update-delete November 27, 2023 10:28
@TiberiuGC TiberiuGC force-pushed the podidentityassociation-update-delete branch from 0535be4 to 0077111 Compare November 27, 2023 10:54
Copy link
Collaborator

@Himangini Himangini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nits

userdocs/src/usage/pod-identity-associations.md Outdated Show resolved Hide resolved
userdocs/theme/home.html Outdated Show resolved Hide resolved
@TiberiuGC TiberiuGC force-pushed the pod-identity-assocition-docs branch 2 times, most recently from 5a37075 to 324d4fd Compare November 27, 2023 13:45
@TiberiuGC TiberiuGC changed the base branch from podidentityassociation-update-delete to main November 27, 2023 13:46
TiberiuGC and others added 3 commits November 27, 2023 15:56
Co-authored-by: Himangini <its_himangini@yahoo.com>
Co-authored-by: Himangini <its_himangini@yahoo.com>
@TiberiuGC TiberiuGC enabled auto-merge (squash) November 27, 2023 14:03
@TiberiuGC TiberiuGC merged commit ce93249 into eksctl-io:main Nov 27, 2023
9 of 10 checks passed
TiberiuGC added a commit to TiberiuGC/eksctl that referenced this pull request Nov 27, 2023
* Add documentation for pod identity associations

* add more details to how pod identity agent addon works

* remove unnecessary empty lines

* refactor as per PR suggestions

* add references to official AWS docs

* generate docs

* rephrase intro

Co-authored-by: Himangini <its_himangini@yahoo.com>

* rephrase news section

Co-authored-by: Himangini <its_himangini@yahoo.com>

* add newline between docs links

---------

Co-authored-by: Himangini <its_himangini@yahoo.com>
TiberiuGC added a commit that referenced this pull request Dec 7, 2023
* Implement updating and deleting pod identity associations (#7315)

* Implement `update podidentityassociation`

* Implement `delete podidentityassociation`

* change create task order

* add integration test

* delete IAM role stacks on cluster deletion

* move validations from cluster config level to command config level

* avoid duplicating stack deletion tasks due to passing name by reference

* fix integration tests

* add eksctl prefix to integrationt test IAM roles

* make IAM roles trust the production EKS Service Principal

---------

Co-authored-by: Tibi <110664232+TiberiuGC@users.noreply.github.com>

* Add documentation for pod identity associations feature (#7313)

* Add documentation for pod identity associations

* add more details to how pod identity agent addon works

* remove unnecessary empty lines

* refactor as per PR suggestions

* add references to official AWS docs

* generate docs

* rephrase intro

Co-authored-by: Himangini <its_himangini@yahoo.com>

* rephrase news section

Co-authored-by: Himangini <its_himangini@yahoo.com>

* add newline between docs links

---------

Co-authored-by: Himangini <its_himangini@yahoo.com>

* update bottlerocket settings reference

---------

Co-authored-by: Chetan Patwal <cPu1@users.noreply.github.com>
Co-authored-by: Himangini <its_himangini@yahoo.com>
IdanShohamNetApp pushed a commit to spotinst/weaveworks-eksctl that referenced this pull request Jun 2, 2024
* Add documentation for pod identity associations

* add more details to how pod identity agent addon works

* remove unnecessary empty lines

* refactor as per PR suggestions

* add references to official AWS docs

* generate docs

* rephrase intro

Co-authored-by: Himangini <its_himangini@yahoo.com>

* rephrase news section

Co-authored-by: Himangini <its_himangini@yahoo.com>

* add newline between docs links

---------

Co-authored-by: Himangini <its_himangini@yahoo.com>
IdanShohamNetApp pushed a commit to spotinst/weaveworks-eksctl that referenced this pull request Jun 2, 2024
* Implement updating and deleting pod identity associations (eksctl-io#7315)

* Implement `update podidentityassociation`

* Implement `delete podidentityassociation`

* change create task order

* add integration test

* delete IAM role stacks on cluster deletion

* move validations from cluster config level to command config level

* avoid duplicating stack deletion tasks due to passing name by reference

* fix integration tests

* add eksctl prefix to integrationt test IAM roles

* make IAM roles trust the production EKS Service Principal

---------

Co-authored-by: Tibi <110664232+TiberiuGC@users.noreply.github.com>

* Add documentation for pod identity associations feature (eksctl-io#7313)

* Add documentation for pod identity associations

* add more details to how pod identity agent addon works

* remove unnecessary empty lines

* refactor as per PR suggestions

* add references to official AWS docs

* generate docs

* rephrase intro

Co-authored-by: Himangini <its_himangini@yahoo.com>

* rephrase news section

Co-authored-by: Himangini <its_himangini@yahoo.com>

* add newline between docs links

---------

Co-authored-by: Himangini <its_himangini@yahoo.com>

* update bottlerocket settings reference

---------

Co-authored-by: Chetan Patwal <cPu1@users.noreply.github.com>
Co-authored-by: Himangini <its_himangini@yahoo.com>
TiberiuGC added a commit to TiberiuGC/eksctl that referenced this pull request Oct 7, 2024
* Add documentation for pod identity associations

* add more details to how pod identity agent addon works

* remove unnecessary empty lines

* refactor as per PR suggestions

* add references to official AWS docs

* generate docs

* rephrase intro

Co-authored-by: Himangini <its_himangini@yahoo.com>

* rephrase news section

Co-authored-by: Himangini <its_himangini@yahoo.com>

* add newline between docs links

---------

Co-authored-by: Himangini <its_himangini@yahoo.com>
TiberiuGC added a commit to TiberiuGC/eksctl that referenced this pull request Oct 7, 2024
* Implement updating and deleting pod identity associations (eksctl-io#7315)

* Implement `update podidentityassociation`

* Implement `delete podidentityassociation`

* change create task order

* add integration test

* delete IAM role stacks on cluster deletion

* move validations from cluster config level to command config level

* avoid duplicating stack deletion tasks due to passing name by reference

* fix integration tests

* add eksctl prefix to integrationt test IAM roles

* make IAM roles trust the production EKS Service Principal

---------

Co-authored-by: Tibi <110664232+TiberiuGC@users.noreply.github.com>

* Add documentation for pod identity associations feature (eksctl-io#7313)

* Add documentation for pod identity associations

* add more details to how pod identity agent addon works

* remove unnecessary empty lines

* refactor as per PR suggestions

* add references to official AWS docs

* generate docs

* rephrase intro

Co-authored-by: Himangini <its_himangini@yahoo.com>

* rephrase news section

Co-authored-by: Himangini <its_himangini@yahoo.com>

* add newline between docs links

---------

Co-authored-by: Himangini <its_himangini@yahoo.com>

* update bottlerocket settings reference

---------

Co-authored-by: Chetan Patwal <cPu1@users.noreply.github.com>
Co-authored-by: Himangini <its_himangini@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/docs User documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants