Implement updating and deleting pod identity associations #7315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TiberiuGC
force-pushed
the
podidentityassociation-update-delete
branch
2 times, most recently
from
523cc4e
to
3871042
Compare
Himangini
approved these changes
Nov 27, 2023
TiberiuGC
changed the base branch from
pod-identity-associations-create
to
main
TiberiuGC
force-pushed
the
podidentityassociation-update-delete
branch
2 times, most recently
from
cc6a35a
to
a0ec448
Compare
TiberiuGC
force-pushed
the
podidentityassociation-update-delete
branch
from
a0ec448
to
3f05578
Compare
TiberiuGC
added a commit
to TiberiuGC/eksctl
that referenced
this pull request
Nov 27, 2023
…7315) * Implement `update podidentityassociation` * Implement `delete podidentityassociation` * change create task order * add integration test * delete IAM role stacks on cluster deletion * move validations from cluster config level to command config level * avoid duplicating stack deletion tasks due to passing name by reference * fix integration tests * add eksctl prefix to integrationt test IAM roles * make IAM roles trust the production EKS Service Principal --------- Co-authored-by: Tibi <110664232+TiberiuGC@users.noreply.github.com>
TiberiuGC
added a commit
that referenced
this pull request
Dec 7, 2023
* Implement updating and deleting pod identity associations (#7315) * Implement `update podidentityassociation` * Implement `delete podidentityassociation` * change create task order * add integration test * delete IAM role stacks on cluster deletion * move validations from cluster config level to command config level * avoid duplicating stack deletion tasks due to passing name by reference * fix integration tests * add eksctl prefix to integrationt test IAM roles * make IAM roles trust the production EKS Service Principal --------- Co-authored-by: Tibi <110664232+TiberiuGC@users.noreply.github.com> * Add documentation for pod identity associations feature (#7313) * Add documentation for pod identity associations * add more details to how pod identity agent addon works * remove unnecessary empty lines * refactor as per PR suggestions * add references to official AWS docs * generate docs * rephrase intro Co-authored-by: Himangini <its_himangini@yahoo.com> * rephrase news section Co-authored-by: Himangini <its_himangini@yahoo.com> * add newline between docs links --------- Co-authored-by: Himangini <its_himangini@yahoo.com> * update bottlerocket settings reference --------- Co-authored-by: Chetan Patwal <cPu1@users.noreply.github.com> Co-authored-by: Himangini <its_himangini@yahoo.com>
IdanShohamNetApp
pushed a commit
to spotinst/weaveworks-eksctl
that referenced
this pull request
Jun 2, 2024
…7315) * Implement `update podidentityassociation` * Implement `delete podidentityassociation` * change create task order * add integration test * delete IAM role stacks on cluster deletion * move validations from cluster config level to command config level * avoid duplicating stack deletion tasks due to passing name by reference * fix integration tests * add eksctl prefix to integrationt test IAM roles * make IAM roles trust the production EKS Service Principal --------- Co-authored-by: Tibi <110664232+TiberiuGC@users.noreply.github.com>
IdanShohamNetApp
pushed a commit
to spotinst/weaveworks-eksctl
that referenced
this pull request
Jun 2, 2024
* Implement updating and deleting pod identity associations (eksctl-io#7315) * Implement `update podidentityassociation` * Implement `delete podidentityassociation` * change create task order * add integration test * delete IAM role stacks on cluster deletion * move validations from cluster config level to command config level * avoid duplicating stack deletion tasks due to passing name by reference * fix integration tests * add eksctl prefix to integrationt test IAM roles * make IAM roles trust the production EKS Service Principal --------- Co-authored-by: Tibi <110664232+TiberiuGC@users.noreply.github.com> * Add documentation for pod identity associations feature (eksctl-io#7313) * Add documentation for pod identity associations * add more details to how pod identity agent addon works * remove unnecessary empty lines * refactor as per PR suggestions * add references to official AWS docs * generate docs * rephrase intro Co-authored-by: Himangini <its_himangini@yahoo.com> * rephrase news section Co-authored-by: Himangini <its_himangini@yahoo.com> * add newline between docs links --------- Co-authored-by: Himangini <its_himangini@yahoo.com> * update bottlerocket settings reference --------- Co-authored-by: Chetan Patwal <cPu1@users.noreply.github.com> Co-authored-by: Himangini <its_himangini@yahoo.com>
TiberiuGC
added a commit
to TiberiuGC/eksctl
that referenced
this pull request
Oct 7, 2024
…7315) * Implement `update podidentityassociation` * Implement `delete podidentityassociation` * change create task order * add integration test * delete IAM role stacks on cluster deletion * move validations from cluster config level to command config level * avoid duplicating stack deletion tasks due to passing name by reference * fix integration tests * add eksctl prefix to integrationt test IAM roles * make IAM roles trust the production EKS Service Principal --------- Co-authored-by: Tibi <110664232+TiberiuGC@users.noreply.github.com>
TiberiuGC
added a commit
to TiberiuGC/eksctl
that referenced
this pull request
Oct 7, 2024
* Implement updating and deleting pod identity associations (eksctl-io#7315) * Implement `update podidentityassociation` * Implement `delete podidentityassociation` * change create task order * add integration test * delete IAM role stacks on cluster deletion * move validations from cluster config level to command config level * avoid duplicating stack deletion tasks due to passing name by reference * fix integration tests * add eksctl prefix to integrationt test IAM roles * make IAM roles trust the production EKS Service Principal --------- Co-authored-by: Tibi <110664232+TiberiuGC@users.noreply.github.com> * Add documentation for pod identity associations feature (eksctl-io#7313) * Add documentation for pod identity associations * add more details to how pod identity agent addon works * remove unnecessary empty lines * refactor as per PR suggestions * add references to official AWS docs * generate docs * rephrase intro Co-authored-by: Himangini <its_himangini@yahoo.com> * rephrase news section Co-authored-by: Himangini <its_himangini@yahoo.com> * add newline between docs links --------- Co-authored-by: Himangini <its_himangini@yahoo.com> * update bottlerocket settings reference --------- Co-authored-by: Chetan Patwal <cPu1@users.noreply.github.com> Co-authored-by: Himangini <its_himangini@yahoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for
eksctl update podidentityassociationandeksctl delete podidentityassociation.Checklist
README.md, or theuserdocsdirectory)area/nodegroup) and kind (e.g.kind/improvement)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯