Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ramp bug on EphemeronLE #110

Open
spudde123 opened this issue Dec 23, 2020 · 0 comments
Open

Ramp bug on EphemeronLE #110

spudde123 opened this issue Dec 23, 2020 · 0 comments

Comments

@spudde123
Copy link
Collaborator

spudde123 commented Dec 23, 2020

The circled ramp on EphemeronLE should connect regions 2 and 5. It was blocked by rocks so it wasn't recognized before, but somehow a point from the edge of region 7 belongs to the ramp and it claimed it connected regions 2 and 7. Now that the connectivity is calculated without the rocks it's a ramp with 3 regions.

ephemeron

eladyaniv01 added a commit that referenced this issue Dec 27, 2020

* feat: use custom implementation of pyastar

downgrade numpy to 1.19.3  for windows users

* feat: fix pyastar ref in requirements

feat: Rewrote add_cost function:
 - Changed open disk to closed disk (add 0.001~)
 - Removed bounds safety check (disk should already do this)
 - Changed order of safe/np.any call to improve performance

feat: Changed all input from ints to floats for better accuracy

* Added 0.01 to find lowest cost points to match add cost

* Improved filtering on nonpathables (#108)

* C pathfinding and chokes (#111)

* add cmapinfo to map_data object

* refactor: change test function names

* refactor: change pathlib choke to cmapchoke in constructs

* refactor: remove sc2pathlib references, use only c extension

* doc: adding comments to extension

* add docs, remove stuff from choke init that is set in the parent class

* changing the way ramp sides are calculated for chokes

* fix wrapper init file

* refactor: moving raw chokes into their own class

* fixing ramps coming from burnysc2

* fix: int cast fix

* test: add a dummy test for the c extension

* feat: changing memory management, remove stretchy buffer dependency

* fix: missing max and min definitions on linux

* remove ephemeronLE from the test maps for now #110

* remove stretchy buffer

* remove sc2pathlib

* changing cext functions to default, removing old test and making a new one

* adjusting small things in pathfinder

* feat: adding overlord drawing

* fix: bug in choke sides

* fix: exception text

* test:  that for each choke a main line actually exists

* Improve find_lowest_cost_efficiency

Directly evaluates set of points in numpy array instead of creating a whole new map grid to compare against
Cost is floored to int

Co-authored-by: shostyn <74581079+shostyn@users.noreply.github.com>
Co-authored-by: shostyn <sashahostyn@yahoo.ca>
Co-authored-by: spudde123 <msandhol@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant