Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix playlist endpoints #20

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Fix playlist endpoints #20

merged 1 commit into from
Jun 12, 2024

Conversation

tgloeggl
Copy link
Member

Use correct endpoint to add / update playlist entries

@tgloeggl tgloeggl added the bug Something isn't working label May 13, 2024
@tgloeggl tgloeggl requested a review from dennis531 May 13, 2024 12:53
dennis531
dennis531 approved these changes May 13, 2024
View reviewed changes
Copy link
Collaborator

@dennis531 dennis531 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't executed the code, but the changes look correct. Thanks for adapting the endpoint to the new oc api version.

@ferishili ferishili changed the title fixes #970 Fix playlist endpoints Jun 11, 2024
@ferishili
Copy link
Contributor

This fixes the playlist issue, and the unit test fails can be ignored in favor of #22

@ferishili ferishili merged commit f656214 into master Jun 12, 2024
16 of 18 checks passed
@ferishili ferishili deleted the fix970 branch June 12, 2024 08:37
@ferishili ferishili mentioned this pull request Jun 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dennis531 dennis531 dennis531 approved these changes

Assignees

@ferishili ferishili

Labels
bug Something isn't working
Projects
SOP V3 Priorisierung
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tgloeggl @ferishili @dennis531