Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reflect changes in the search service for OC 16. #22

Merged
merged 4 commits into from
Jun 13, 2024
Merged

Reflect changes in the search service for OC 16. #22

merged 4 commits into from
Jun 13, 2024

Conversation

tgloeggl
Copy link
Member

@tgloeggl tgloeggl commented May 17, 2024 •
edited
Loading

  • Remove lucene search, does not exists anymore
  • Update allowed sort params and their spelling
  • Update tests

Some things need to be discussed:

  • Is it necessary to have the api versioned or is graceful degration enough (to get it to work with oc 16 AND before)?

There also seems to be a bug in OC which needs to be addressed first (the sort order currently only works with title)

Fixes #21

@tgloeggl tgloeggl added the enhancement New feature or request label May 17, 2024
@tgloeggl tgloeggl requested a review from ferishili May 17, 2024 07:54
@tgloeggl
Copy link
Member Author

tgloeggl commented Jun 12, 2024 •
edited
Loading

similar to activateIngest / enableIngest

This was referenced Jun 12, 2024
Merged
Merged
@tgloeggl tgloeggl marked this pull request as ready for review June 13, 2024 09:51
@ferishili ferishili merged commit 662afa8 into master Jun 13, 2024
18 checks passed
@ferishili ferishili deleted the oc-16 branch June 13, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferishili ferishili Awaiting requested review from ferishili

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
SOP V3 Priorisierung
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Changes necessary for OC 16
2 participants
@tgloeggl @ferishili