Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return link without validations is potentially unsafe #720

Closed
LukasKalbertodt opened this issue Sep 9, 2020 · 0 comments · Fixed by #721
Closed

Return link without validations is potentially unsafe #720

LukasKalbertodt opened this issue Sep 9, 2020 · 0 comments · Fixed by #721
Labels
priority:high High priority

Comments

@LukasKalbertodt
Copy link
Member

The feature introduced in #674 is problematic. This was noticed by @luniki. Some article about this security concern: https://cheatsheetseries.owasp.org/cheatsheets/Unvalidated_Redirects_and_Forwards_Cheat_Sheet.html

One solution would be to have a whitelist of domains that can be redirected to. That whitelist would only be configurable via settings.toml and NOT via GET parameters. This would also mean that other apps already using return.target and return.label don't have to change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:high High priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant