Fix redirect security #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulianKniephoff
approved these changes
Sep 14, 2020
This is useful for some security related settings. We don't want attackers to send around Studio links with malicious GET parameters.
This is technically a breaking change, but it's clearly a bug. Before, it was possible to use something like `loginProvided = "true"` in the TOML encoded as the `config` GET parameter. That makes no sense.
This setting can only be set from `settings.toml`. That way, we avoid attackers sending out Studio links with `return.target` set to bad URLs.
LukasKalbertodt
force-pushed
the
fix-redirect-security
branch
from
d9b0034
to
8677621
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #720
CC @luniki