Add possibility to show and configure a "go back" button in final step #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion Often, Studio feels somewhat like a dead end. In the end, the user is just offered to record a new recording. But usually, the user wants to leave or return to the page they are coming from. This commit makes that possible.
LukasKalbertodt
force-pushed
the
back-link
branch
from
f5d4166
to
79b9c28
Compare
|
We decided not to have an extra solution for situations where studio is opened in a new tab. As we cannot close that tab, we can only show a text box "if you want to return, close this tab" ... which is not ideal. We rather expect LMS to stop opening Studio in a new tab once this feature lands, as Studio is not a "dead end" anymore. |
LukasKalbertodt
added a commit
to elan-ev/opencast-ilias
that referenced
this pull request
Aug 7, 2020
Opencast Studio added support for passing a return link (including a label). Studio then shows a "Quit and go back" button in the last step (after recording). This avoids users getting trapped in UI dead ends. See this Studio PR for more information: elan-ev/opencast-studio#674 Note that on older Studio versions, adding these parameters does nothing. A warning about "unknown parameter" is printed in the browser dev console, but other than that, the parameters are ignored. One might think about making the label configurable in the plugin's configuration. But "ILIAS" is a good default I guess.
This was referenced Aug 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #593
Often, Studio feels somewhat like a dead end. In the end, the user is
just offered to record a new recording. But usually, the user wants to
leave or return to the page they are coming from. This commit makes
that possible.
We might want to have a better solution for when Studio is opened in a new tab still.
For the record: I decided against a solution that uses or can be configured to use
document.referrer. While passingreturn.target=referrerlooks good, relying on the referrer is a fragile solution. The referrer can get lost for a couple of reasons. Additionally, the referrer can be unexpected -- for example, Opencast might forward/studioto the login page when the user is not authenticated, meaning that the login page will be the referrer. We can always add thereferreroption later when people really want it, but I don't think it's a great idea.