Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace cmd hotkey declaration with mod #1120

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Replace cmd hotkey declaration with mod #1120

merged 1 commit into from
Sep 26, 2023

Conversation

owi92
Copy link
Member

@owi92 owi92 commented Sep 26, 2023

Apparently cmd is not a valid keycode (anymore?).

Fixes #1100

@owi92
Replace cmd hotkey declaration with mod
dd8092e 
Apparently `cmd` is not a valid keycode (anymore?).
@owi92 owi92 added the type:usability This would improve usability label Sep 26, 2023
LukasKalbertodt
LukasKalbertodt approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@LukasKalbertodt LukasKalbertodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you tested on a mac, and I don't own a mac, and since the code changes are fine (obviously :D) ... approval!

@LukasKalbertodt LukasKalbertodt merged commit ab155e0 into elan-ev:master Sep 26, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasKalbertodt LukasKalbertodt LukasKalbertodt approved these changes

Assignees
No one assigned
Labels
type:usability This would improve usability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Forward/back shortcuts don't work at all on macOS
2 participants
@owi92 @LukasKalbertodt