Skip to content

Commit

Permalink
Update Paella and add support for fallback fullscreen mode on iOS (#1113
Browse files Browse the repository at this point in the history
)

Fixes #1070 -> well, there is still one warning remaining, but that
needs to be fixed inside Paella and is more complicated to get rid of.
See polimediaupv/paella-core#354

Fixes #990 -> well, this doesn't add volume controls back but the
reasoning for hiding those is somewhat sane, so that part is #wontfix.

The fullscreen fallback mode for Safari was suggested here:
polimediaupv/paella-core#355 But it was moved
into the plugin by the Paella devs.
  • Loading branch information
owi92 authored Feb 21, 2024
2 parents a683184 + ee37292 commit a9d06eb
Show file tree
Hide file tree
Showing 3 changed files with 23 additions and 11 deletions.
18 changes: 9 additions & 9 deletions frontend/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions frontend/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@
"hls.js": "^1.4.12",
"i18next": "^23.5.1",
"i18next-browser-languagedetector": "^7.1.0",
"paella-basic-plugins": "1.44.2",
"paella-core": "1.46.1",
"paella-basic-plugins": "1.44.4",
"paella-core": "1.46.6",
"paella-skins": "1.32.4",
"paella-zoom-plugin": "1.41.1",
"qrcode.react": "^3.1.0",
Expand Down
12 changes: 12 additions & 0 deletions frontend/src/ui/player/Paella.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,9 @@ const PaellaPlayer: React.FC<PaellaPlayerProps> = ({
return <>
<Global styles={{
"body > .popup-container": colors,
"body:has(.paella-fallback-fullscreen)": {
overflow: "hidden",
},
}} />
<div
// We use `key` here to force React to re-create this `div` and not
Expand Down Expand Up @@ -215,6 +218,15 @@ const PaellaPlayer: React.FC<PaellaPlayerProps> = ({
transform: "translate(1px, -2px)",
},
},

"&.paella-fallback-fullscreen": {
position: "fixed",
top: 0,
left: 0,
right: 0,
bottom: 0,
zIndex: 100000,
},
}}
/>
</>;
Expand Down

0 comments on commit a9d06eb

Please sign in to comment.