Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of random warnings and errors in the console #1070

Closed
LukasKalbertodt opened this issue Jan 10, 2024 · 1 comment · Fixed by #1113
Closed

Get rid of random warnings and errors in the console #1070

LukasKalbertodt opened this issue Jan 10, 2024 · 1 comment · Fixed by #1113
Labels
area:frontend Everything frontend related kind:improvement
Milestone
v2.6

Comments

@LukasKalbertodt
Copy link
Member

  • If the frontend is build in debug mode, this is shown: "Using kebab-case for css properties in objects is not supported. Did you mean WebkitTextSizeAdjust?"
  • As soon as Paella is loaded, we get big errors regarding removeChild. And a ton of other warnings. We should probably look into this to see if there is anything we can improve.
@LukasKalbertodt LukasKalbertodt added area:frontend Everything frontend related kind:improvement labels Jan 10, 2024
LukasKalbertodt added a commit to LukasKalbertodt/tobira that referenced this issue Jan 11, 2024
@LukasKalbertodt
Fix debug warning about non-camelCase emotion property
cc066db 
This results in the correct `-webkit-text-size-adjust: none` in the
resulting CSS. Addresses part of elan-ev#1070.
@LukasKalbertodt
Copy link
Member Author

First part is already fixed, second part is fixed partially by polimediaupv/paella-core#353

@LukasKalbertodt LukasKalbertodt added this to the v2.6 milestone Feb 14, 2024
@owi92 owi92 modified the milestones: v2.6, v2.7 Feb 21, 2024
LukasKalbertodt added a commit to LukasKalbertodt/tobira that referenced this issue Feb 21, 2024
@LukasKalbertodt
Update Paella and add support for fallback fullscreen mode on iOS
ee37292 
Fixes elan-ev#1070 -> well, there is still one warning remaining, but that
needs to be fixed inside Paella and is more complicated to get rid of.
See polimediaupv/paella-core#354

Fixes elan-ev#990 -> well, this doesn't add volume controls back but the
reasoning for hiding those is somewhat sane, so that part is #wontfix.

The fullscreen fallback mode for Safari was suggested here:
polimediaupv/paella-core#355
But it was moved into the plugin by the Paella devs.
@LukasKalbertodt LukasKalbertodt mentioned this issue Feb 21, 2024
Merged
owi92 added a commit that referenced this issue Feb 21, 2024
@owi92
Update Paella and add support for fallback fullscreen mode on iOS (#1113
a9d06eb 
)

Fixes #1070 -> well, there is still one warning remaining, but that
needs to be fixed inside Paella and is more complicated to get rid of.
See polimediaupv/paella-core#354

Fixes #990 -> well, this doesn't add volume controls back but the
reasoning for hiding those is somewhat sane, so that part is #wontfix.

The fullscreen fallback mode for Safari was suggested here:
polimediaupv/paella-core#355 But it was moved
into the plugin by the Paella devs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:frontend Everything frontend related kind:improvement
Projects
None yet
Milestone
v2.6
Development

Successfully merging a pull request may close this issue.

Update Paella and add support for fallback fullscreen mode on iOS LukasKalbertodt/tobira
2 participants
@LukasKalbertodt @owi92