Fix bug in loadStyle and add destroy method for cleanup
#353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is intended to undo all side effects caused by the constructor. Required for SPAs.
The promise accidentally returned nothing, meaning that `undefined` was pushed to `__skinStyleSheets__`. Later, that undefined was passed to `head.removeChild`, throwing an error.
ferserc1
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
In Tobira we noticed that unloading a Paella instance and loading a new one caused some console errors and other weird behavior. This PR tries to address some of that. The first commit adds a
destroymethod which does a complete cleanup. This is very useful for SPAs like Tobira, where Paella instances are created and destroyed again, and that shouldn't leave any traces. Without thisdestroymethod, certain event handlers and other global values still exist. Thedestroymethod fixes that.The second commit is a simple bug fix where a promise sometimes returned
undefined(by callingresolve()without arguments). Thatundefinedvalue is later passed to a function that throws an error. You can see that on tobira.opencast.org when clicking on one video and then on a second one.I hope these changes are ok like this!