feat: set DENYLIST_URL env var for bitswap-peer #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure DENYLIST_URL is set in env. see: elastic-ipfs/bitswap-peer#215 License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
vasco-santos
approved these changes
Jul 5, 2023
helm/values.yaml
Outdated
| @@ -60,5 +60,6 @@ env: | |||
| dynamodbLinkTableV1: prod-ep-v1-blocks-cars-position | |||
| dynamodbConfigTable: prod-ep-bitswap-config | |||
| p2pConnectionMaxConnections: 5000 | |||
| denylistUrl: https://denylist.dag.haus | |||
There was a problem hiding this comment.
Do we want to start with staging in prod?
olizilla
added a commit
to elastic-ipfs/bitswap-peer
that referenced
this pull request
Jul 5, 2023
- cap the max number of cids we'll accept in a single message. - We're seeing 20k spikes in our `bitswap-pending-entries` metrics per node, so I'm putting in a hard cap of 500 wanted cids per message that we'll process. The caller can ask again if they need more. This also means i can put a sensible cap on how many cids the denylist service should handle in a batch. - check batches of cids against our denylist api. - cache entries that are on the denylist; they are rarely removed. - use cache to avoid asking about items we already know, and as a fallback if denylist service cannot be reached. - add `bitswap-denied` counter metric to see how many CIDs we skip due to being on the denylist see: batch endpoint for denylist api – storacha/reads#166 see: set DENYLIST_URL in env - elastic-ipfs/bitswap-peer-deployment#99 License: MIT --------- Signed-off-by: Oli Evans <oli@protocol.ai>
see: elastic-ipfs/bitswap-peer#215 License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
we suspect that adding extra load to the denylist api will have us hit rate limits on cloudflare. so we will roll this out against staging which very little traffic but the entire denylist dataset to see how it fares against that first. if it works well without hitting limits against the staging url, then we'll move it to prod and monitor it. if it starts to hit limits we'll have to either get them raised, or consider deploying an additional denylist api just for e-ipfs (or consider other routes like sync-ing the denylist api to a db in aws) License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure DENYLIST_URL is set in env when deploying bitswap-peer
see: elastic-ipfs/bitswap-peer#215
License: MIT