feat: add batch denylist check #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Send an array of CID strings to check if they are on the denylist. Reponse is the subset of the array that is on the denylist. ```http POST / Content-Type: application/json ["cid1","cid2"] ``` License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
alanshaw
approved these changes
Jun 22, 2023
packages/denylist/src/denylist.js
Outdated
| * @param {import('./env').Env} env | ||
| */ | ||
| export async function denylistPost (request, env) { | ||
| if (!request.json) { |
There was a problem hiding this comment.
AFAIK this is not undefined if content-type is not json...
There was a problem hiding this comment.
ah yes, right, i was following the itty-route request type which defines .json as optional, but isn't want i want to test for here. Fixing!
License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
olizilla
added a commit
to elastic-ipfs/bitswap-peer
that referenced
this pull request
Jul 5, 2023
- cap the max number of cids we'll accept in a single message. - We're seeing 20k spikes in our `bitswap-pending-entries` metrics per node, so I'm putting in a hard cap of 500 wanted cids per message that we'll process. The caller can ask again if they need more. This also means i can put a sensible cap on how many cids the denylist service should handle in a batch. - check batches of cids against our denylist api. - cache entries that are on the denylist; they are rarely removed. - use cache to avoid asking about items we already know, and as a fallback if denylist service cannot be reached. - add `bitswap-denied` counter metric to see how many CIDs we skip due to being on the denylist see: batch endpoint for denylist api – storacha/reads#166 see: set DENYLIST_URL in env - elastic-ipfs/bitswap-peer-deployment#99 License: MIT --------- Signed-off-by: Oli Evans <oli@protocol.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Send an array of CID strings to check if they are on the denylist. Response is the subset of the array that is on the denylist.
This will be used by e-ipfs to check a batch of cids at once, see: elastic-ipfs/bitswap-peer#215
License: MIT