Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Update link to APM server #387

Merged
merged 1 commit into from
Aug 20, 2019

Conversation

bmorelli25
Copy link
Member

The RUM Agent links to literal anchors in the APM Server documentation. These links will break on the switch from asciidoc to asciidoctor. This PR fixes the link to use new anchor tags added in elastic/apm-server#2603.

Backport to 4.x.

For elastic/apm-server#1965. Full error log available in elastic/docs#1083 (comment).

@bmorelli25
Copy link
Member Author

@elasticmachine, run elasticsearch-ci/docs

2 similar comments
@bmorelli25
Copy link
Member Author

@elasticmachine, run elasticsearch-ci/docs

@bmorelli25
Copy link
Member Author

@elasticmachine, run elasticsearch-ci/docs

@bmorelli25
Copy link
Member Author

Finally got the docs CI green. Feel free to merge if this looks good to you. Thanks!

Copy link
Member

@vigneshshanmugam vigneshshanmugam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bmorelli25, feel free to merge it once tests passes

@bmorelli25 bmorelli25 merged commit 3b44eb0 into elastic:master Aug 20, 2019
@bmorelli25 bmorelli25 deleted the docs-asciidoctor-fixes branch August 20, 2019 21:42
@codecov-io
Copy link

Codecov Report

Merging #387 into master will decrease coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master     #387     +/-   ##
=========================================
- Coverage   94.58%   94.49%   -0.1%     
=========================================
  Files          38       38             
  Lines        1756     1727     -29     
  Branches      350      340     -10     
=========================================
- Hits         1661     1632     -29     
  Misses         95       95
Impacted Files Coverage Δ
packages/rum/src/bootstrap.js 90.9% <0%> (-1.95%) ⬇️
...rum-core/src/performance-monitoring/transaction.js 98.61% <0%> (-0.37%) ⬇️

David-Development pushed a commit to David-Development/apm-agent-rum-js that referenced this pull request Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants