Switch APM Server to Asciidoctor

[bmorelli25]

See elastic/apm-server#1965 for all updates.

📖⛷👨‍⚕

[bmorelli25]

Sorry, tagged the wrong Nik initially.

[bmorelli25]

Well, dang.

INFO:build_docs:/tmp/docsbuild/target_repo/html/en/apm/server/7.1/index.xml:1533: element xref: validity error : IDREF attribute linkend references an unknown ID "configuration-autodiscover-hints"

Which is here:
https://github.com/elastic/apm-server/blame/4e817c7da50b58e8a8ba9dbafed4902b3ad3a0b5/docs/copied-from-beats/shared-docker.asciidoc#L198-L217

The problem is that this shouldn't even be executed. The if should evaluate to false and not display at all.

[nik9000]

I talked with Brandon about this and we tracked it down to complex ifevals. Asciidoctor silently considers then all true. I believe this is a bug that they fixed in a version after the one we are using!

…

On Mon, Aug 19, 2019, 17:14 Brandon Morelli ***@***.***> wrote: Well, dang. INFO:build_docs:/tmp/docsbuild/target_repo/html/en/apm/server/7.1/index.xml:1533: element xref: validity error : IDREF attribute linkend references an unknown ID "configuration-autodiscover-hints" Which is here: https://github.com/elastic/apm-server/blame/4e817c7da50b58e8a8ba9dbafed4902b3ad3a0b5/docs/copied-from-beats/shared-docker.asciidoc#L198-L217 The problem is that this shouldn't even be executed. The if should evaluate to false and not display at all. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#1083?email_source=notifications&email_token=AABUXIUWFWZZPFO43DJ66LTQFMEJ7A5CNFSM4INGGBS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4UKCCA#issuecomment-522756360>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABUXIVTPWQPYRBQ5W3BY3TQFMEJ7ANCNFSM4INGGBSQ> .

[bmorelli25]

@elasticmachine, run elasticsearch-ci/docs

[bmorelli25]

New errors below. Chatted with Nik. These are because asciidoctor and asciidoc handle links differently. One uses _ and the other uses _literal. I need to update these cross doc links to fix.

09:33:28 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/apm/agent/js-base/4.x/getting-started.html:
09:33:28 INFO:build_docs:   - en/apm/server/current/configuration-rum.html#_literal_allow_origins_literal
09:33:28 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/apm/agent/js-base/current/getting-started.html:
09:33:28 INFO:build_docs:   - en/apm/server/current/configuration-rum.html#_literal_allow_origins_literal
09:33:28 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/apm/agent/js-base/master/getting-started.html:
09:33:28 INFO:build_docs:   - en/apm/server/current/configuration-rum.html#_literal_allow_origins_literal
09:33:28 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/apm/agent/rum-js/4.x/getting-started.html:
09:33:28 INFO:build_docs:   - en/apm/server/current/configuration-rum.html#_literal_allow_origins_literal
09:33:28 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/apm/agent/rum-js/current/getting-started.html:
09:33:28 INFO:build_docs:   - en/apm/server/current/configuration-rum.html#_literal_allow_origins_literal
09:33:28 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/apm/agent/rum-js/master/getting-started.html:
09:33:28 INFO:build_docs:   - en/apm/server/current/configuration-rum.html#_literal_allow_origins_literal
09:33:28 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/cloud-heroku/current/ech-manage-apm-settings.html:
09:33:28 INFO:build_docs:   - en/apm/server/7.3/configuration-rum.html#_literal_library_pattern_literal
09:33:28 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/cloud-heroku/release-ms-25/ech-manage-apm-settings.html:
09:33:28 INFO:build_docs:   - en/apm/server/7.3/configuration-rum.html#_literal_library_pattern_literal
09:33:28 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/cloud/current/ec-manage-apm-settings.html:
09:33:28 INFO:build_docs:   - en/apm/server/7.3/configuration-rum.html#_literal_library_pattern_literal
09:33:28 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/cloud/release-ms-25/ec-manage-apm-settings.html:
09:33:28 INFO:build_docs:   - en/apm/server/7.3/configuration-rum.html#_literal_library_pattern_literal

[bmorelli25]

@elasticmachine, run elasticsearch-ci/docs

[bmorelli25]

Oooo exciting! elasticsearch-ci/docs passes! The diff is a bit crazy right now: http://docs_1083.docs-preview.app.elstc.co/diff.

Still a lot of PRs to merge that should hopefully reduce the changes.

Blocked by:

• https://github.com/elastic/cloud/pull/38301
• the backport for ^
• [docs] Update link to APM server apm-agent-rum-js#387
• [docs][4.x] Update link to APM server  apm-agent-rum-js#388
• removing python from <= 6.8

[bmorelli25]

@elasticmachine, run elasticsearch-ci/docs

[bmorelli25]

To consolidate things, I'm going to stop posting updates in this PR. All updates will now be in the meta issue: elastic/apm-server#1965.

[bmorelli25]

@elasticmachine, run elasticsearch-ci/docs

[nik9000]

LGTM any time!

[bmorelli25]

Everything looks ready 🤞.