Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][6.8] Remove arbitrary python expressions #2600

Merged
merged 3 commits into from
Aug 21, 2019

Conversation

bmorelli25
Copy link
Member

For elastic/docs#1083. A few more problems that weren't showing up on the local build.

In Asciidoctor, the old python expressions with or all evaluate to true. This PR updates them to ifdef or ifndef directives.

@bmorelli25
Copy link
Member Author

The diff is not as expected. I messed up somewhere on this one.

+21 -2 en/apm/server/6.8/command-line-options.html
+2 -1 en/apm/server/6.8/configuration-path.html
+1 -2 en/apm/server/6.8/elasticsearch-output.html
+1 -2 en/apm/server/6.8/kafka-output.html
+1 -2 en/apm/server/6.8/logstash-output.html

@bmorelli25
Copy link
Member Author

Turns out the :apm-server: attribute doesn't exist in <7.0

@elasticmachine, run elasticsearch-ci/docs

@bmorelli25
Copy link
Member Author

bmorelli25 commented Aug 21, 2019

Built HTML diff is now empty as expected.

@bmorelli25 bmorelli25 merged commit c9a3f62 into elastic:6.8 Aug 21, 2019
@bmorelli25 bmorelli25 deleted the 6.8-fields-fix branch August 21, 2019 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant