Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: step hasCommentAuthorWritePermissions #1064

Merged

Conversation

kuisathaverat
Copy link
Contributor

What does this PR do?

it adds a new step to check the permissions of a comment author.

@kuisathaverat kuisathaverat added enhancement New feature or request automation Team:Automation Label for the Observability productivity team labels Mar 30, 2021
@kuisathaverat kuisathaverat requested a review from a team March 30, 2021 16:15
@kuisathaverat kuisathaverat self-assigned this Mar 30, 2021
@botelastic botelastic bot added the groovy label Mar 30, 2021
vars/README.md Outdated Show resolved Hide resolved
vars/README.md Outdated Show resolved Hide resolved
@apmmachine
Copy link
Contributor

apmmachine commented Mar 30, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #1064 updated

  • Start Time: 2021-03-30T16:16:20.136+0000

  • Duration: 44 min 27 sec

  • Commit: ccf8d33

Test stats 🧪

Test Results
Failed 0
Passed 1091
Skipped 2
Total 1093

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 1091
Skipped 2
Total 1093

Copy link
Contributor

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was a clear candidate to a step 👍

@kuisathaverat kuisathaverat merged commit 1bca010 into elastic:master Mar 31, 2021
v1v referenced this pull request in v1v/apm-pipeline-library Apr 6, 2021
* 'master' of github.com:elastic/apm-pipeline-library: (40 commits)
  Fix and simplify buildStatus step (#1066)
  Add benchmark reporter image to build pipeline (#1065)
  docs: update CHANGELOG.md
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release v1.1.207
  feat: stage status cache (#1061)
  feat: step hasCommentAuthorWritePermissions (#1064)
  ARM workers are now ephemeral (#1062)
  docs: update metricbeat step docs (#1057)
  Update beats-ci workers for the test-infra validation (#1058)
  feat: allow to remove padding (#1059)
  mergify: priority is now a pro feature (#1060)
  docs: update CHANGELOG.md
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release v1.1.206
  chore(deps): bump groovy-eclipse-batch from 3.0.7-02 to 3.0.7-03 (#1045)
  chore: bump Elastic Stack versions (#1052)
  Add GCE JCasC (#1053)
  feat: metricbeat step (#1050)
  chore: refactor filebeat step (#1049)
  ...
v1v added a commit that referenced this pull request Apr 18, 2021
* upstream/master: (56 commits)
  docs: update CHANGELOG.md
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release v1.1.209
  security: disable codecov bash updater
  chore(deps-dev): bump mockito-core from 3.8.0 to 3.9.0 (#1073)
  fix: use toJSON instead readJSON (#1071)
  test-infra: add curl validation on windows (#1069)
  CI: skip using ubuntu label in the beats test-infra (#1070)
  test: add Ubuntu 20.04 to the tests (#1068)
  docs: update CHANGELOG.md
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release v1.1.208
  Disable unique ephemeral worker by default (#1067)
  Fix and simplify buildStatus step (#1066)
  Add benchmark reporter image to build pipeline (#1065)
  docs: update CHANGELOG.md
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release v1.1.207
  feat: stage status cache (#1061)
  feat: step hasCommentAuthorWritePermissions (#1064)
  ...
@kuisathaverat kuisathaverat deleted the hasCommentAuthorWritePermissions branch July 19, 2021 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation enhancement New feature or request groovy Team:Automation Label for the Observability productivity team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants