Disable unique ephemeral worker by default #1067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 'master' of github.com:elastic/apm-pipeline-library: (40 commits) Fix and simplify buildStatus step (#1066) Add benchmark reporter image to build pipeline (#1065) docs: update CHANGELOG.md [maven-release-plugin] prepare for next development iteration [maven-release-plugin] prepare release v1.1.207 feat: stage status cache (#1061) feat: step hasCommentAuthorWritePermissions (#1064) ARM workers are now ephemeral (#1062) docs: update metricbeat step docs (#1057) Update beats-ci workers for the test-infra validation (#1058) feat: allow to remove padding (#1059) mergify: priority is now a pro feature (#1060) docs: update CHANGELOG.md [maven-release-plugin] prepare for next development iteration [maven-release-plugin] prepare release v1.1.206 chore(deps): bump groovy-eclipse-batch from 3.0.7-02 to 3.0.7-03 (#1045) chore: bump Elastic Stack versions (#1052) Add GCE JCasC (#1053) feat: metricbeat step (#1050) chore: refactor filebeat step (#1049) ...
This reverts commit 7ead24b.
mdelapenya
approved these changes
Apr 6, 2021
cachedout
approved these changes
Apr 6, 2021
kuisathaverat
approved these changes
Apr 6, 2021
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
v1v
referenced
this pull request
in v1v/apm-pipeline-library
Apr 7, 2021
* 'master' of github.com:elastic/apm-pipeline-library: test: add Ubuntu 20.04 to the tests (#1068) docs: update CHANGELOG.md [maven-release-plugin] prepare for next development iteration [maven-release-plugin] prepare release v1.1.208 Disable unique ephemeral worker by default (#1067) t checkout -b# the commit.
v1v
added a commit
that referenced
this pull request
Apr 18, 2021
* upstream/master: (56 commits) docs: update CHANGELOG.md [maven-release-plugin] prepare for next development iteration [maven-release-plugin] prepare release v1.1.209 security: disable codecov bash updater chore(deps-dev): bump mockito-core from 3.8.0 to 3.9.0 (#1073) fix: use toJSON instead readJSON (#1071) test-infra: add curl validation on windows (#1069) CI: skip using ubuntu label in the beats test-infra (#1070) test: add Ubuntu 20.04 to the tests (#1068) docs: update CHANGELOG.md [maven-release-plugin] prepare for next development iteration [maven-release-plugin] prepare release v1.1.208 Disable unique ephemeral worker by default (#1067) Fix and simplify buildStatus step (#1066) Add benchmark reporter image to build pipeline (#1065) docs: update CHANGELOG.md [maven-release-plugin] prepare for next development iteration [maven-release-plugin] prepare release v1.1.207 feat: stage status cache (#1061) feat: step hasCommentAuthorWritePermissions (#1064) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add
forceWorkerparameter to enable the UUID label allocation. By default it's not enabled.Why is it important?
There is an existing issue with the Gobld provisioner and the development process.
Development process might commit and push several times, every pushed commit will trigger a build in the CI, and the obsoleted builds matching obsoleted commits will be cancelled if they are still running (there is no need to test the old commits but the new ones). If some of those workers were not assigned yet to the cancelled builds, there will be idling for 10 minutes and don't release the slot for a new worker. Therefore the CI capacity gets decreased.
This should mitigate this particular scenario.