fix: check that docker is installed #3889
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3889 +/- ##
==========================================
- Coverage 79.80% 79.72% -0.09%
==========================================
Files 135 135
Lines 6194 6194
==========================================
- Hits 4943 4938 -5
- Misses 1251 1256 +5
|
| do | ||
| (retry 2 docker pull ${image}) || echo "Error pulling ${image} Docker image, we continue" | ||
| done | ||
| fi |
There was a problem hiding this comment.
What happens if docker is not installed? Will the CI just finish and pass?
There was a problem hiding this comment.
for those packer images that do not have Docker installed packer will skip the docker pull, doing that, the build success. This does not affect to the APM server build, we do not use those images for builds, they are used for testing OS.
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Steps errorsExpand to view the steps failures
|
* chore(ci): move CI scripts to the .ci directory (#4452) * chore(ci): movee windows scripts to the CI location * chore(ci): move more scripts * chore(ci): move check-changelogs to CI folder * chore(ci): move intake script to CI dir * chore(ci): move bench script * chore(ci): move sync script * chore(ci): move package to CI dir * chore(ci): move test-install to CI dir * chore(ci): remove unused windows script * ci: remove cron trigger from the check changelog job (#3957) * fix: ci build and test of the golang-mage docker image (#3563) * [CI][docker] prepare required context (#4136) * packer: cache docker images (#3620) * fix: check that docker is installed (#3889) * Update Jenkinsfile Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com> Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com> Co-authored-by: Ivan Fernandez Calvo <kuisathaverat@users.noreply.github.com> Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
What does this PR do?
It checks that Docker is installed before run it.
Why is it important?
Some worker types do not have Docker installed this breaks the packer build.