Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI][docker] prepare required context #4136

Merged
merged 1 commit into from
Sep 2, 2020
Merged

[CI][docker] prepare required context #4136

merged 1 commit into from
Sep 2, 2020

Conversation

v1v
Copy link
Member

@v1v v1v commented Sep 2, 2020 •
edited by zube bot
Loading

Motivation/summary

Docker image requires some files in the specific folder, let's copy them

How to test these changes

$ make -C .ci/docker all-tests

Related issues

Caused by #4112

@v1v v1v self-assigned this Sep 2, 2020
@v1v v1v added the automation label Sep 2, 2020
@v1v v1v mentioned this pull request Sep 2, 2020
Closed
@v1v v1v requested review from axw and a team September 2, 2020 11:24
@v1v v1v marked this pull request as ready for review September 2, 2020 11:24
@axw
Copy link
Member

axw commented Sep 2, 2020

What does this fix? As in, what's the problem that I missed in the first place? Should something have failed more obviously...?

@apmmachine
Copy link
Contributor

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #4136 opened]

  • Start Time: 2020-09-02T11:22:52.522+0000

  • Duration: 45 min 21 sec

Test stats 🧪

Test Results
Failed 0
Passed 3255
Skipped 142
Total 3397

Steps errors

Expand to view the steps failures

  • Name: Compress

    • Description: tar --exclude=coverage-files.tgz -czf coverage-files.tgz coverage

    • Duration: 0 min 0 sec

    • Start Time: 2020-09-02T11:38:09.513+0000

    • log

  • Name: Compress

    • Description: tar --exclude=system-tests-linux-files.tgz -czf system-tests-linux-files.tgz system-tests

    • Duration: 0 min 0 sec

    • Start Time: 2020-09-02T11:52:33.357+0000

    • log

  • Name: Test Sync

    • Description: ./script/jenkins/sync.sh

    • Duration: 3 min 47 sec

    • Start Time: 2020-09-02T11:33:07.701+0000

    • log

@v1v
Copy link
Member Author

v1v commented Sep 2, 2020

What does this fix? As in, what's the problem that I missed in the first place? Should something have failed more obviously...?

Fixes the docker image generations which happens once a day with the pipeline apm-docker-images-pipeline

That particular pipeline failed when generating those docker images:

The problem was with the makefile wrapper

@v1v v1v merged commit 17548de into elastic:master Sep 2, 2020
@v1v v1v deleted the fix/docker-image branch September 2, 2020 13:43
simitt pushed a commit to simitt/apm-server that referenced this pull request Dec 15, 2020
@v1v @simitt
[CI][docker] prepare required context (elastic#4136)
e446e73
simitt added a commit that referenced this pull request Dec 16, 2020
@simitt @mdelapenya
@kuisathaverat @v1v
[7.x] [ci] backports (#4546)
c0b9d19 
* chore(ci): move CI scripts to the .ci directory (#4452)

* chore(ci): movee windows scripts to the CI location

* chore(ci): move more scripts

* chore(ci): move check-changelogs to CI folder

* chore(ci): move intake script to CI dir

* chore(ci): move bench script

* chore(ci): move sync script

* chore(ci): move package to CI dir

* chore(ci): move test-install to CI dir

* chore(ci): remove unused windows script

* ci: remove cron trigger from the check changelog job (#3957)

* fix: ci build and test of the golang-mage docker image (#3563)

* [CI][docker] prepare required context (#4136)

* packer: cache docker images (#3620)

* fix: check that docker is installed (#3889)

* Update Jenkinsfile

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>

Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com>
Co-authored-by: Ivan Fernandez Calvo <kuisathaverat@users.noreply.github.com>
Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axw axw axw approved these changes

@kuisathaverat kuisathaverat kuisathaverat approved these changes

Assignees

@v1v v1v

Labels
automation bug ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@v1v @axw @apmmachine @kuisathaverat