systemtest: add tests for aggregation and sampling #4084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Steps errorsExpand to view the steps failures
|
axw
force-pushed
the
aggregation-system-tests
branch
from
b90a471
to
8c14462
Compare
simitt
reviewed
Aug 25, 2020
|
It's going to take a bit to shuffle the approvals code around, so I'll move the PR back into draft for now. |
Migrate aggregation and sampling system tests to Go. As part of this we introduce "approval" test support. The implementation is a little different to the one in the Python system tests: the Python ones ignore various dynamic fields when computing the diff; we replace dynamic fields before comparing, so the approved diffs don't change in unrelated ways every time there is an expected change, such as a new field.
If we don't consume the response, the server may (non-determinstically) log an error.
axw
force-pushed
the
aggregation-system-tests
branch
from
10d1ce3
to
589e133
Compare
Codecov Report
@@ Coverage Diff @@
## master #4084 +/- ##
=======================================
Coverage 80.34% 80.34%
=======================================
Files 142 142
Lines 6712 6712
=======================================
Hits 5393 5393
Misses 1319 1319 |
simitt
approved these changes
Sep 3, 2020
axw
added a commit
to axw/apm-server
that referenced
this pull request
Sep 8, 2020
* systemtest: add tests for aggregation and sampling Migrate aggregation and sampling system tests to Go. As part of this we introduce "approval" test support. The implementation is a little different to the one in the Python system tests: the Python ones ignore various dynamic fields when computing the diff; we replace dynamic fields before comparing, so the approved diffs don't change in unrelated ways every time there is an expected change, such as a new field. * systemtest: update aggregation config * Check result in TestTransactionAggregationShutdown * systemtest: fix logging test If we don't consume the response, the server may (non-determinstically) log an error. * Update approved files
axw
added a commit
that referenced
this pull request
Sep 8, 2020
* systemtest: add tests for aggregation and sampling Migrate aggregation and sampling system tests to Go. As part of this we introduce "approval" test support. The implementation is a little different to the one in the Python system tests: the Python ones ignore various dynamic fields when computing the diff; we replace dynamic fields before comparing, so the approved diffs don't change in unrelated ways every time there is an expected change, such as a new field. * systemtest: update aggregation config * Check result in TestTransactionAggregationShutdown * systemtest: fix logging test If we don't consume the response, the server may (non-determinstically) log an error. * Update approved files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Migrate aggregation and sampling system tests to Go.
As part of this we introduce "approval" test support.
The implementation is a little different to the Python
version: the Python version ignores various dynamic
fields when computing the diff, whereas in this version
we replace dynamic fields before comparing, so the
approved files don't change in unrelated ways every
time there is an expected change, such as a new field.
Checklist
- [ ] I have updated CHANGELOG.asciidocI have considered changes for:
- [ ] documentation- [ ] logging (add log lines, choose appropriate log selector, etc.)- [ ] metrics and monitoring (create issue for Kibana team to add metrics to visualizations, e.g. Kibana#44001)- [ ] telemetry- [ ] Elasticsearch Service (https://cloud.elastic.co)- [ ] Elastic Cloud Enterprise (https://www.elastic.co/products/ece)- [ ] Elastic Cloud on Kubernetes (https://www.elastic.co/elastic-cloud-kubernetes)How to test these changes
cd systemtest && go test -v
Related issues
None.