Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] systemtest: add tests for aggregation and sampling (#4084) #4171

Merged
merged 1 commit into from
Sep 8, 2020

Conversation

axw
Copy link
Member

@axw axw commented Sep 8, 2020

Backports the following commits to 7.x:

* systemtest: add tests for aggregation and sampling

Migrate aggregation and sampling system tests to Go.

As part of this we introduce "approval" test support.
The implementation is a little different to the one
in the Python system tests: the Python ones ignore
various dynamic fields when computing the diff; we
replace dynamic fields before comparing, so the
approved diffs don't change in unrelated ways every
time there is an expected change, such as a new field.

* systemtest: update aggregation config

* Check result in TestTransactionAggregationShutdown

* systemtest: fix logging test

If we don't consume the response, the server
may (non-determinstically) log an error.

* Update approved files
@axw axw added the backport label Sep 8, 2020
@apmmachine
Copy link
Contributor

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #4171 opened]

  • Start Time: 2020-09-08T03:33:24.578+0000

  • Duration: 30 min 13 sec

Test stats 🧪

Test Results
Failed 0
Passed 3039
Skipped 136
Total 3175

Steps errors

Expand to view the steps failures

  • Name: Compress

    • Description: tar --exclude=coverage-files.tgz -czf coverage-files.tgz coverage

    • Duration: 0 min 0 sec

    • Start Time: 2020-09-08T03:49:36.624+0000

    • log

  • Name: Compress

    • Description: tar --exclude=system-tests-linux-files.tgz -czf system-tests-linux-files.tgz system-tests

    • Duration: 0 min 0 sec

    • Start Time: 2020-09-08T04:03:35.641+0000

    • log

  • Name: Test Sync

    • Description: ./script/jenkins/sync.sh

    • Duration: 3 min 54 sec

    • Start Time: 2020-09-08T03:44:11.754+0000

    • log

@axw axw merged commit 236108e into elastic:7.x Sep 8, 2020
@axw axw deleted the backport/7.x/pr-4084 branch September 8, 2020 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants