Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Sync Libbeat documentation #5185

Merged
merged 6 commits into from
May 3, 2021

Conversation

bmorelli25
Copy link
Member

@bmorelli25 bmorelli25 commented Apr 28, 2021

Summary

Originally a follow-up to #5113, but turned into something more. This PR copies over documentation from the Beats repo.

I think everything in this PR makes sense in the APM Server Reference, but I'd appreciate someone from the apm-server team taking a look.

More information

This PR backports documentation changes from the following PRs:

Backport to...

Commits in this PR need to be backported to different branches:

@bmorelli25 bmorelli25 added the Team:Docs Label for the Observability docs team label Apr 28, 2021
@bmorelli25 bmorelli25 requested a review from a team April 28, 2021 22:33
@bmorelli25 bmorelli25 self-assigned this Apr 28, 2021
@apmmachine
Copy link
Contributor

apmmachine commented Apr 28, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #5185 updated

  • Start Time: 2021-04-29T21:32:17.772+0000

  • Duration: 38 min 4 sec

  • Commit: de79e36

Test stats 🧪

Test Results
Failed 0
Passed 6294
Skipped 120
Total 6414

Trends 🧪

Image of Build Times

Image of Tests

Copy link
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spotted one small thing, which I guess will need fixing in the beats repo. LGTM otherwise

docs/copied-from-beats/docs/shared-path-config.asciidoc Outdated Show resolved Hide resolved
@bmorelli25 bmorelli25 merged commit 0d0f80f into elastic:master May 3, 2021
@bmorelli25 bmorelli25 deleted the sync-beats-docs branch May 3, 2021 22:20
@bmorelli25 bmorelli25 restored the sync-beats-docs branch May 3, 2021 22:25
@bmorelli25 bmorelli25 deleted the sync-beats-docs branch May 3, 2021 22:31
This was referenced May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Docs Label for the Observability docs team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants