Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libbeat] Expose the new Sarama flag 'DisablePAFXFAST' in the Kafka output #23629

Merged
merged 5 commits into from
Jan 22, 2021
Merged

[libbeat] Expose the new Sarama flag 'DisablePAFXFAST' in the Kafka output #23629

merged 5 commits into from
Jan 22, 2021

Conversation

faec
Copy link
Contributor

@faec faec commented Jan 21, 2021 •
edited
Loading

What does this PR do?

This PR adds the new flag enable_krb5_fast to the Kafka output, which (un)sets the DisablePAFXFAST flag added in Sarama 1.27.0. FAST authentication via Sarama can conflict with Active Directory, so this flag is off by default.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@faec faec requested a review from urso January 21, 2021 21:04
@faec faec requested review from a team as code owners January 21, 2021 21:04
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jan 21, 2021
@faec faec added the Team:Elastic-Agent Label for the Agent team label Jan 21, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/agent (Team:Agent)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jan 21, 2021
@faec faec added the libbeat label Jan 21, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jan 21, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #23629 updated

    • Start Time: 2021-01-21T21:29:28.799+0000

  • Duration: 46 min 3 sec

  • Commit: b86d864

Test stats 🧪

Test Results
Failed 0
Passed 17343
Skipped 1346
Total 18689

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 17343
Skipped 1346
Total 18689

@faec faec merged commit 621c9e2 into elastic:master Jan 22, 2021
@faec faec deleted the sarama-flag branch January 22, 2021 02:25
@faec faec mentioned this pull request Jan 25, 2021
Merged
6 tasks
@faec faec added the v7.12.0 label Jan 25, 2021
faec added a commit to faec/beats that referenced this pull request Jan 25, 2021
@faec
[libbeat] Expose the new Sarama flag 'DisablePAFXFAST' in the Kafka o…
408b5d5 
…utput (elastic#23629)

(cherry picked from commit 621c9e2)
faec added a commit that referenced this pull request Jan 26, 2021
@faec
Cherry-pick #23629 to 7.x: [libbeat] Expose the new Sarama flag 'Disa…
e8ade83 
…blePAFXFAST' in the Kafka output (#23665)
@bmorelli25 bmorelli25 mentioned this pull request Apr 28, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urso urso urso approved these changes

Assignees
No one assigned
Labels
enhancement libbeat Team:Elastic-Agent Label for the Agent team v7.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@faec @elasticmachine @urso