-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry-pick #23629 to 7.x: [libbeat] Expose the new Sarama flag 'DisablePAFXFAST' in the Kafka output #23665
Conversation
…utput (elastic#23629) (cherry picked from commit 621c9e2)
Pinging @elastic/agent (Team:Agent) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
...the automation thinks this is "most likely a genuine test failure," but it's definitely not related to this change (failure link). Not sure yet if the failure is consistent. |
After retrying with no changes to the PR or base branch, the failing test passes, but now a different test fails. |
After syncing to the latest 7.x branch (albeit with no obviously relevant changes), the preceding tests all pass, but now a new one fails. auditbeat-windows-windows-2019
|
Hopefully final update: after running the tests again, with no further changes to the PR or base branch, they finally all passed. |
Cherry-pick of PR #23629 to 7.x branch. Original message:
What does this PR do?
This PR adds the new flag
enable_krb5_fast
to the Kafka output, which (un)sets theDisablePAFXFAST
flag added in Sarama 1.27.0. FAST authentication via Sarama can conflict with Active Directory, so this flag is off by default.Checklist
I have commented my code, particularly in hard-to-understand areasI have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.