Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cloud metadata to agent development docs #290

Merged
merged 4 commits into from
Jul 6, 2020

Conversation

basepi
Copy link
Contributor

@basepi basepi commented Jun 30, 2020

Ref #256

Agent Milestone Link to agent implementation issue
.NET 7.10 elastic/apm-agent-dotnet#918
Go 7.10 elastic/apm-agent-go#786
Java 7.10 elastic/apm-agent-java#1264
Node.js 7.10 elastic/apm-agent-nodejs#1815
PHP 7.10 elastic/apm-agent-php#76
Python 7.9 elastic/apm-agent-python#822
Ruby 7.10 elastic/apm-agent-ruby#841
RUM n/a n/a

@basepi basepi requested a review from felixbarny June 30, 2020 15:22
docs/agents/agent-development.md Show resolved Hide resolved
@felixbarny
Copy link
Member

Once #289 is resolved, I'd also add the option name, the values, the default and the description to this PR.

I'd also add some more detail around how the metadata can be obtained or alternatively link to python as the reference implementation. Also add that Delay intake API requests until with have computed the metadata (queuing events in the mean time) is the recommended way to init the meta data.

@basepi basepi merged commit 1cb071c into elastic:master Jul 6, 2020
@felixbarny felixbarny linked an issue Sep 3, 2020 that may be closed by this pull request
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Agents should collect cloud identification metadata
3 participants