-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove min value for exit_span_min_duration
#607
Remove min value for exit_span_min_duration
#607
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1us was probably "disabled" for all intents and purposes, but having the ability to explicitly disable is good.
This is scheduled to be merged in 2 days |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewing again on behalf of the Python agent
Remove min value for
exit_span_min_duration
to allow opting out of dropping fast exit spans.This may impact the existing implementations for .NET, Go, PHP, Python, and the in-progress implementation for Java. However, it seems most have not implemented a validation that would disallow users to set
exit_span_min_duration
to 0.CODEOWNERS
)To auto-merge the PR, add
/
schedule YYYY-MM-DD
to the PR description./schedule 2022-03-10