Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove min value for exit_span_min_duration #607

Merged
merged 2 commits into from
Mar 10, 2022

Conversation

felixbarny
Copy link
Member

@felixbarny felixbarny commented Mar 7, 2022

Remove min value for exit_span_min_duration to allow opting out of dropping fast exit spans.

This may impact the existing implementations for .NET, Go, PHP, Python, and the in-progress implementation for Java. However, it seems most have not implemented a validation that would disallow users to set exit_span_min_duration to 0.

  • Create PR as draft
  • Approval by at least one other agent
  • Mark as Ready for Review (automatically requests reviews from all agents and PM via CODEOWNERS)
    • Remove PM from reviewers if impact on product is negligible
    • Remove agents from reviewers if the change is not relevant for them
  • Merge after 2 business days passed without objections
    To auto-merge the PR, add /schedule YYYY-MM-DD to the PR description.

/schedule 2022-03-10

@felixbarny felixbarny requested a review from marclop March 7, 2022 09:13
@apmmachine
Copy link

apmmachine commented Mar 7, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-03-10T10:01:36.749+0000

  • Duration: 3 min 22 sec

Copy link
Contributor

@basepi basepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1us was probably "disabled" for all intents and purposes, but having the ability to explicitly disable is good.

@felixbarny felixbarny marked this pull request as ready for review March 8, 2022 18:09
@felixbarny felixbarny requested review from a team as code owners March 8, 2022 18:09
@felixbarny felixbarny removed the request for review from a team March 8, 2022 18:09
@felixbarny
Copy link
Member Author

This is scheduled to be merged in 2 days

Copy link
Contributor

@basepi basepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing again on behalf of the Python agent

@github-actions github-actions bot merged commit d1b2b96 into main Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants