-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable dropping fast exit spans by default #610
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basepi
approved these changes
Mar 8, 2022
jackshirazi
approved these changes
Mar 8, 2022
This is scheduled to be merged in 2 days |
gregkalapos
approved these changes
Mar 8, 2022
5 tasks
SergeyKleyman
approved these changes
Mar 8, 2022
@@ -22,7 +22,7 @@ Additionally, spans that lead to an error can't be discarded. | |||
| | | | |||
|----------------|------------| | |||
| Type | `duration` | | |||
| Default | `1ms` | | |||
| Default | `0ms` | | |||
| Central config | `true` | | |||
|
|||
The minimum allowed duration for this setting is `1us` (microsecond). Agents may need to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems the new default contradicts this requirement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is handled in #607
trentm
approved these changes
Mar 8, 2022
basepi
approved these changes
Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in the weekly, we'd like to disable dropping fast exit spans by default.
CODEOWNERS
)To auto-merge the PR, add
/
schedule YYYY-MM-DD
to the PR description./schedule 2022-03-10