Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable dropping fast exit spans by default #610

Merged
merged 1 commit into from
Mar 10, 2022

Conversation

felixbarny
Copy link
Member

@felixbarny felixbarny commented Mar 8, 2022

As discussed in the weekly, we'd like to disable dropping fast exit spans by default.

  • What's considered "fast" is application-specific and coming up with a good default that works for all users isn't easy.
  • While 1ms seems like a reasonable threshold, it can still be a significant event if the total duration of a request is 10ms
  • A prerequisite to dropping fast exit spans by default is adding indicators to the UI that tell users something like "we dropped 42 spans to Redis which accounted for 21ms in total"
  • We also want to get more feedback from our user base before dropping fast exit spans by default.

  • Create PR as draft
  • Approval by at least one other agent
  • Mark as Ready for Review (automatically requests reviews from all agents and PM via CODEOWNERS)
    • Remove PM from reviewers if impact on product is negligible
    • Remove agents from reviewers if the change is not relevant for them
  • Merge after 2 business days passed without objections
    To auto-merge the PR, add /schedule YYYY-MM-DD to the PR description.

/schedule 2022-03-10

@apmmachine
Copy link

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-03-08T17:41:32.099+0000

  • Duration: 3 min 8 sec

@felixbarny felixbarny marked this pull request as ready for review March 8, 2022 18:11
@felixbarny felixbarny requested review from a team as code owners March 8, 2022 18:11
@felixbarny
Copy link
Member Author

This is scheduled to be merged in 2 days

@@ -22,7 +22,7 @@ Additionally, spans that lead to an error can't be discarded.
| | |
|----------------|------------|
| Type | `duration` |
| Default | `1ms` |
| Default | `0ms` |
| Central config | `true` |

The minimum allowed duration for this setting is `1us` (microsecond). Agents may need to
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the new default contradicts this requirement.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is handled in #607

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants