Skip to content

Commit

Permalink
Add release tag to metricset templates (#10657)
Browse files Browse the repository at this point in the history
We were having contributions of metricsets with the release level in
the description, the cause was that our generator scripts did it this
way.

Add release tag to metricset templates instead of using the description
field for this purpouse.

Make beta the release level for new modules by default. Experimental
should be kept just for real experiments or in some corner cases. The
usual level for a new metricset that collects metrics from a known
existing service or technology should be beta (or ga if it is really
complete).
  • Loading branch information
jsoriano authored Feb 14, 2019
1 parent 1dc58e0 commit 6952697
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
1 change: 1 addition & 0 deletions CHANGELOG-developer.next.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -33,3 +33,4 @@ The list below covers the major changes between 7.0.0-alpha2 and master only.
- Introduce ILM and IndexManagment support to beat.Settings. {pull}10347[10347]
- Introduce ILM and IndexManagement support to beat.Settings. {pull}10347[10347]
- Generating index pattern on demand instead of shipping them in the packages. {pull}10478[10478]
- Metricset generator generates beta modules by default now. {pull}10657[10657]
3 changes: 1 addition & 2 deletions metricbeat/scripts/module/fields.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
- key: {module}
title: "{module}"
release: beta
description: >
experimental[]
{module} module
fields:
- name: {module}
Expand Down
2 changes: 1 addition & 1 deletion metricbeat/scripts/module/metricset/metricset.go.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ type MetricSet struct {
// New creates a new instance of the MetricSet. New is responsible for unpacking
// any MetricSet specific configuration options if there are any.
func New(base mb.BaseMetricSet) (mb.MetricSet, error) {
cfgwarn.Experimental("The {module} {metricset} metricset is experimental.")
cfgwarn.Beta("The {module} {metricset} metricset is beta.")

config := struct{}{}
if err := base.Module().UnpackConfig(&config); err != nil {
Expand Down

0 comments on commit 6952697

Please sign in to comment.