Add release tag to metricset templates #10657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsoriano
added
review
Metricbeat
kaiyan-sheng
approved these changes
Feb 11, 2019
ruflin
approved these changes
Feb 11, 2019
sayden
approved these changes
Feb 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were having contributions of metricsets with the release level in
the description, the cause was that our generator scripts did it this
way.
Add release tag to metricset templates instead of using the description
field for this purpouse.
Make beta the release level for new modules by default. Experimental
should be kept just for real experiments or in some corner cases. The
usual level for a new metricset that collects metrics from a known
existing service or technology should be beta (or ga if it is really
complete).