Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Set MODULE per relevant stage #19986

Closed
v1v opened this issue Jul 16, 2020 · 0 comments · Fixed by #19985
Closed

[CI] Set MODULE per relevant stage #19986

v1v opened this issue Jul 16, 2020 · 0 comments · Fixed by #19985
Assignees
Labels
automation ci Team:Automation Label for the Observability productivity team

Comments

@v1v
Copy link
Member

v1v commented Jul 16, 2020

#18741 was done but the regex in place is such a generic one that did not filter per module.

For instance, given the changeset:

CHANGELOG.next.asciidoc
NOTICE.txt
auditbeat/module/auditd/audit.go
auditbeat/module/auditd/config_linux.go
go.mod
go.sum

The current value for the environment variable MODULE is 'auditd' when running the Integration tests stage for the metricbeat, when the expected output should be ''

Test Scenarios

The below test scenarios should help to identify what the behaviour should be:

Single module changeset

When changeset:

CHANGELOG.next.asciidoc
NOTICE.txt
auditbeat/module/auditd/audit.go
auditbeat/module/auditd/config_linux.go
go.mod
go.sum

Then:

  • auditbeat should set the MODULE to auditd
  • metricbeat should set the MODULE to ''

Multi module changeset

When changeset:

CHANGELOG.next.asciidoc
NOTICE.txt
auditbeat/module/system/system.go
auditbeat/module/auditd/config_linux.go
go.mod
go.sum

Then:

  • auditbeat should set the MODULE to ''
  • metricbeat should set the MODULE to ''

single module changeset in multiple beats

When changeset:

CHANGELOG.next.asciidoc
NOTICE.txt
auditbeat/module/auditd/config_linux.go
metricbeat/module/system/system.go
go.mod
go.sum

Then:

  • auditbeat should set the MODULE to auditd
  • metricbeat should set the MODULE to system

multiple module changeset in multiple beats

When changeset:

CHANGELOG.next.asciidoc
NOTICE.txt
auditbeat/module/system/system.go
auditbeat/module/auditd/config_linux.go
metricbeat/module/system/system.go
metricbeat/module/logstash/connection/connection.go
go.mod
go.sum

Then:

  • auditbeat should set the MODULE to ''
  • metricbeat should set the MODULE to ''
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation ci Team:Automation Label for the Observability productivity team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant