-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry-pick #19300 to 7.x: Update to go-libaudit v2.0.0 #19908
Conversation
Pinging @elastic/siem (Team:SIEM) |
* Update to go-libaudit v2.0.0 This updates the go-libaudit library to v2.0.0. Some of the updates since the last release were already incorporated into Beats. https://github.com/elastic/go-libaudit/releases/tag/v2.0.0 Fixes elastic#14055 (seccomp field enrichments) Fixes a few minor typos and spelling issues in auditd event.category and event.action values. * Only import go-libaudit on linux (cherry picked from commit 4f3d950)
017909a
to
9b3ec40
Compare
I've been seeing this unusual error from the Metricbeat tests:
I tracked down some discussion of it to #18592 (comment). In this case the MODULE=auditd but that's only an Auditbeat module. Similarly I saw this with a Filebeat module change that triggered Metricbeat to build and it failed for the same reason (logs). // fyi: @jsoriano @v1v |
@andrewkroh , that particular misbehaviour was theoretically solved with #18777 and backported. I'll run some tests locally and see if i can reproduce the behaviour for this PR |
I see what's going on:
should use If I recall we used the generic pattern to be easy to handle all the cases, but it seems it's not 100% accurate. I've just raised #19986 to explain the reason of the issue and some test scenarios that should be verified when doing the implementation. |
Thanks @v1v ! |
Cherry-pick of PR #19300 to 7.x branch. Original message:
What does this PR do?
This updates the go-libaudit library to v2.0.0. Some of the updates since the last release were already
incorporated into Beats.
https://github.com/elastic/go-libaudit/releases/tag/v2.0.0
Fixes #14055 (seccomp field enrichments)
Fixes a few minor typos and spelling issues in auditd event.category and event.action values.