Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky test: service_integration_windows_test.go #8880

Closed
ph opened this issue Nov 1, 2018 · 0 comments · Fixed by #11662
Closed

Flaky test: service_integration_windows_test.go #8880

ph opened this issue Nov 1, 2018 · 0 comments · Fixed by #11662
Assignees
@narph
Labels
flaky-test Unstable or unreliable test cases. Metricbeat Metricbeat Team:Integrations Label for the Integrations team :Windows

Comments

@ph
Copy link
Contributor

ph commented Nov 1, 2018

I've seen this when creating #8859, I only saw it once.

service_integration_windows_test.go:79: 
		Error Trace:	service_integration_windows_test.go:79
		Error:      	Not equal: 
		            	expected: 0x0
		            	actual  : 0x154
		Test:       	TestReadService
		Messages:   	PID of service Background Intelligent Transfer Service does not match
service_integration_windows_test.go:82: 
		Error Trace:	service_integration_windows_test.go:82
		Error:      	Not equal: 
		            	expected: "Stopped"
		            	actual  : "Running"
		            	
		            	Diff:
		            	--- Expected
		            	+++ Actual
		            	@@ -1 +1 @@
		            	-Stopped
		            	+Running
		Test:       	TestReadService
		Messages:   	State of service Background Intelligent Transfer Service does not match
```
@ph ph added the flaky-test Unstable or unreliable test cases. label Nov 1, 2018
@ruflin ruflin added Metricbeat Metricbeat Team:Integrations Label for the Integrations team labels Feb 7, 2019
@narph narph assigned narph and unassigned andrewkroh Apr 4, 2019
@narph narph added the :Windows label Apr 4, 2019
@narph narph mentioned this issue Apr 5, 2019
Merged
narph added a commit to narph/beats that referenced this issue Apr 15, 2019
@narph
Fix flaky service_integration_windows_test
9d0ea44 
Some services can change state before reader.Read() call is executed which will result in a test faillure.
Fix test by introducing a confidence factor and enriching the error message with the state-changed service details.

Fixes elastic#8880 and elastic#7977
narph added a commit that referenced this issue Apr 15, 2019
@narph
Fix flaky service_integration_windows_test (#11662)
88b88f7 
* Fix flaky service_integration_windows_test

Some services can change state before reader.Read() call is executed which will result in a test faillure.
Fix test by introducing a confidence factor and enriching the error message with the state-changed service details.

Fixes #8880 and #7977

* Update metricbeat/module/windows/service/service_integration_windows_test.go

Co-Authored-By: narph <mariana@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@narph narph

Labels
flaky-test Unstable or unreliable test cases. Metricbeat Metricbeat Team:Integrations Label for the Integrations team :Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix flaky service_integration_windows_test narph/beats
5 participants
@ph @ruflin @narph @andrewkroh @alvarolobato