-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a goformation fork to go around MAX_PATH limitation #8859
Use a goformation fork to go around MAX_PATH limitation #8859
Conversation
The goformation library is pretty liberal with the lenght of the file it uses, this seems to mess up our windows CI because we reach the MAX_PATH limit.
c6f61a8
to
22bf76b
Compare
can we add vendor/ into .gitignore? |
@kaiyan-sheng I understand the pain of having the dependencies in the project, there are also advantages. I think we could discuss that in another issue or with the issue discussing moving from govendor to another tool #8070 |
I never seen the above fails before, I will trigger another CI run to see if its a flaky test or not and do a followup issue. |
jenkins test this please |
The goformation library is pretty liberal with the lenght of the file it uses, this seems to mess up our windows CI because we reach the MAX_PATH limit. Followup issue for moving back to original lib elastic#8857 (cherry picked from commit 2423c65)
The goformation library is pretty liberal with the lenght of the file it uses, this seems to mess up our windows CI because we reach the MAX_PATH limit. Followup issue for moving back to original lib elastic#8857 (cherry picked from commit 2423c65)
elastic#8882) The goformation library is pretty liberal with the lenght of the file it uses, this seems to mess up our windows CI because we reach the MAX_PATH limit. Followup issue for moving back to original lib elastic#8857 (cherry picked from commit 9a4f572)
The goformation library is pretty liberal with the lenght of the file it uses, this seems to mess up our windows CI because we reach the MAX_PATH limit.
Followup issue for moving back to original lib #8857