Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a goformation fork to go around MAX_PATH limitation #8859

Merged
merged 1 commit into from
Nov 1, 2018
Merged

Use a goformation fork to go around MAX_PATH limitation #8859

merged 1 commit into from
Nov 1, 2018

Conversation

ph
Copy link
Contributor

@ph ph commented Oct 31, 2018 •
edited

The goformation library is pretty liberal with the lenght of the file it uses, this seems to mess up our windows CI because we reach the MAX_PATH limit.

Followup issue for moving back to original lib #8857

@ph ph mentioned this pull request Oct 31, 2018
Closed
@ph ph requested a review from urso October 31, 2018 19:06
@ph ph added the needs_backport PR is waiting to be backported to other branches. label Oct 31, 2018
@ph ph assigned urso Oct 31, 2018
@ph
Use a goformation fork to go around MAX_PATH limitation
22bf76b 
The goformation library is pretty liberal with the lenght of the file it uses, this seems to mess
up our windows CI because we reach the MAX_PATH limit.
@ph ph force-pushed the fix/use-shorterfile-from-cloudformation-2 branch from c6f61a8 to 22bf76b Compare October 31, 2018 19:43
@kaiyan-sheng
Copy link
Contributor

can we add vendor/ into .gitignore?

@ph
Copy link
Contributor Author

ph commented Oct 31, 2018

@kaiyan-sheng I understand the pain of having the dependencies in the project, there are also advantages. I think we could discuss that in another issue or with the issue discussing moving from govendor to another tool #8070

@ph
Copy link
Contributor Author

ph commented Oct 31, 2018 

service_integration_windows_test.go:79: 
		Error Trace:	service_integration_windows_test.go:79
		Error:      	Not equal: 
		            	expected: 0x0
		            	actual  : 0x154
		Test:       	TestReadService
		Messages:   	PID of service Background Intelligent Transfer Service does not match
service_integration_windows_test.go:82: 
		Error Trace:	service_integration_windows_test.go:82
		Error:      	Not equal: 
		            	expected: "Stopped"
		            	actual  : "Running"
		            	
		            	Diff:
		            	--- Expected
		            	+++ Actual
		            	@@ -1 +1 @@
		            	-Stopped
		            	+Running
		Test:       	TestReadService
		Messages:   	State of service Background Intelligent Transfer Service does not match

I never seen the above fails before, I will trigger another CI run to see if its a flaky test or not and do a followup issue.

@ph
Copy link
Contributor Author

ph commented Oct 31, 2018

jenkins test this please

@ph ph mentioned this pull request Nov 1, 2018
Closed
@ph ph merged commit 2423c65 into elastic:master Nov 1, 2018
ph added a commit to ph/beats that referenced this pull request Nov 1, 2018
@ph
Use a goformation fork to go around MAX_PATH limitation (elastic#8859)
57a782b 
The goformation library is pretty liberal with the lenght of the file it uses, this seems to mess up our windows CI because we reach the MAX_PATH limit.


Followup issue for moving back to original lib elastic#8857

(cherry picked from commit 2423c65)
@ph ph mentioned this pull request Nov 1, 2018
Merged
@ph ph added v6.6.0 and removed needs_backport PR is waiting to be backported to other branches. labels Nov 1, 2018
ph added a commit to ph/beats that referenced this pull request Nov 1, 2018
@ph
Use a goformation fork to go around MAX_PATH limitation (elastic#8859)
be2165a 
The goformation library is pretty liberal with the lenght of the file it uses, this seems to mess up our windows CI because we reach the MAX_PATH limit.


Followup issue for moving back to original lib elastic#8857

(cherry picked from commit 2423c65)
@ph ph mentioned this pull request Nov 1, 2018
Merged
@ph ph added the v6.5.0 label Nov 1, 2018
ph added a commit that referenced this pull request Nov 2, 2018
@ph
Use a goformation fork to go around MAX_PATH limitation (#8859) (#8881)
9b6cf08 
The goformation library is pretty liberal with the lenght of the file it uses, this seems to mess up our windows CI because we reach the MAX_PATH limit.


Followup issue for moving back to original lib #8857

(cherry picked from commit 2423c65)
ph added a commit that referenced this pull request Nov 2, 2018
@ph
Use a goformation fork to go around MAX_PATH limitation (#8859) (#8882)
0920cc2 
The goformation library is pretty liberal with the lenght of the file it uses, this seems to mess up our windows CI because we reach the MAX_PATH limit.


Followup issue for moving back to original lib #8857

(cherry picked from commit 2423c65)
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@ph
Use a goformation fork to go around MAX_PATH limitation (elastic#8859) (
d78bd75 
elastic#8882)

The goformation library is pretty liberal with the lenght of the file it uses, this seems to mess up our windows CI because we reach the MAX_PATH limit.


Followup issue for moving back to original lib elastic#8857

(cherry picked from commit 9a4f572)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urso urso urso approved these changes

Assignees

@urso urso

Labels
Functionbeat review v6.5.0 v6.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ph @kaiyan-sheng @urso