Winlogbeat Fix an issue with caching #1100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add expvar metrics for the cache (hits/misses/size). Add strict validation for top-level YAML keys in winlogbeat config.
| // Validate validates the Settings data and returns an error describing | ||
| // all problems or nil if there are none. | ||
| func (s Settings) Validate() error { | ||
| validKeys := []string{"winlogbeat", "output", "shipper", "logging"} |
There was a problem hiding this comment.
That looks like something we should move to libbeat, as these 4 keys must exist for each beat.
ruflin
added a commit
that referenced
this pull request
Mar 3, 2016
Winlogbeat Fix an issue with caching
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example expvar cache metrics are shown below. I just wanted to make the cache a bit more "observable" for the debugging purposes.