Winlogbeat: add caching of metadata handles #888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. I would suggest to update the CHANGELOG. |
…or wineventlog API
andrewkroh
force-pushed
the
feature/winlogbeat-caching
branch
from
e4c46cd
to
c0fc105
Compare
ruflin
added a commit
that referenced
this pull request
Feb 1, 2016
Winlogbeat: add caching of metadata handles
andrewkroh
added a commit
to andrewkroh/beats
that referenced
this pull request
Mar 3, 2016
Add expvar metrics for the cache (hits/misses/size). Add strict validation for top-level YAML keys in winlogbeat config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caching is already part of the eventlogging implementation, but it wasn't yet added to the wineventlog implementation. This gives a performance boost to Winlogbeat.