Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport config env var replacement, topbeat username/cmdline #1113

Merged
merged 6 commits into from
Mar 10, 2016

Conversation

andrewkroh
Copy link
Member

Backport features to v1.2

andrewkroh and others added 6 commits March 4, 2016 09:51
Containing the command line used to start the process, together with
the arguments separated by space.

Conflicts:
	etc/fields.yml
Adding go-ole as a vendored dependency
Adding StackExchange/wmi as a vendored dependency
Updating gosigar version
Omit proc.cmdline if empty and update process test
@monicasarbu
Copy link
Contributor

waiting to be green

@monicasarbu
Copy link
Contributor

@andrewkroh Ready for review?

@andrewkroh
Copy link
Member Author

I manually re-ran the Jenkins build. Sucess - http://build-eu-00.elastic.co/job/Beats-PR/825/

This PR is ready for review.

@andrewkroh andrewkroh closed this Mar 8, 2016
@andrewkroh andrewkroh deleted the 1.2 branch March 8, 2016 23:23
@andrewkroh andrewkroh restored the 1.2 branch March 8, 2016 23:23
@andrewkroh andrewkroh deleted the 1.2 branch March 8, 2016 23:24
@andrewkroh andrewkroh restored the 1.2 branch March 8, 2016 23:25
@andrewkroh andrewkroh reopened this Mar 8, 2016
@ruflin
Copy link
Member

ruflin commented Mar 10, 2016

LGTM. @monicasarbu Do you also want to have a look?

monicasarbu added a commit that referenced this pull request Mar 10, 2016
Backport config env var replacement, topbeat username/cmdline
@monicasarbu monicasarbu merged commit f1157b0 into elastic:1.2 Mar 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants