Merge pull request 773 (adding username to topbeat) #845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. We should really add a system test case for |
|
@andrewkroh Good point. I think it's easy enough for me to add it in this one, so we're sure we don't forget about it. |
|
I implemented a test case for this and opened a PR to this branch. tsg#1 |
Add Topbeat system test for process username
|
Sub-PR merged :) |
andrewkroh
added a commit
that referenced
this pull request
Jan 26, 2016
Merge pull request 773 (adding username to topbeat)
|
Could you please update the field_name that is exposed by this change in the [list of topbeat fields ].(https://github.com/elastic/beats/blob/master/topbeat/docs/fields.asciidoc). Is it |
|
It's |
andrewkroh
added a commit
to andrewkroh/beats
that referenced
this pull request
Mar 30, 2016
Backport of elastic#1128 to 1.2 - Change Cpu.Get() on Windows to not use floating point arithmetic
This was referenced Mar 30, 2016
andrewkroh
added a commit
to andrewkroh/beats
that referenced
this pull request
Apr 6, 2016
Backport of elastic#845 to 1.2.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is merging #773 and in addition updating the vendored gosigar.