Removed topbeat username from 1.2 changelog #1261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andrewkroh I looked into backporting it myself, but because there are a few commits split between gosigar and topbeat, this didn't look like a safe last minute change, so I'd rather just take it out from the advertised new features. Let me know if I missed something obvious. |
|
😞 You're right, I missed most of the #845 PR in my cherry-pick. I thought it was there with the system test for Username. |
tsg
force-pushed
the
remove_username_from_changelog
branch
from
4e11411
to
4f6899d
Compare
tsg
force-pushed
the
remove_username_from_changelog
branch
from
4f6899d
to
9999c77
Compare
|
@andrewkroh So it looks like process username was not included in 1.2 release if I understand correctly? Any guidance on if it will be included in the 5.0 release? Is there anything i can do to help fix any problems with the PR to help assure inclusion in 5.0? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like the PRs were not (fully) backported. In my tests, the username
doesn't show up on Linux and OS X, and looking at the code I think it doesn't
work on any of the platforms.