Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.x][Backport] create ActiveMQ Metricbeat module #14792

Closed
wants to merge 7 commits into from
Closed

[7.x][Backport] create ActiveMQ Metricbeat module #14792

wants to merge 7 commits into from

Conversation

mtojek
Copy link
Contributor

@mtojek mtojek commented Nov 26, 2019

This PR cherry-picks all changes related to the ActiveMQ Metricbeat module development:

31e3ed4
4db5135
9a9408b
b9481d3

Master issue: #14510

Steps done:

$ ./dev-tools/cherrypick_pr --create_pr 7.x 14580 b9481d3a900f668f52fedf63b9006ee9557848a2 9a9408bc90b91d0401ebcf49996208c8a5ba123b 4db5135b4647bc834584207791ae45821cabccb4 31e3ed4d97789647d4f8eee8b2b18cbadf08b703

mtojek and others added 6 commits November 26, 2019 12:15
@mtojek
[Metricbeat] Create ActiveMQ module (elastic#14580)
1343b0e 
* Generate bootstrap for broker, queue, topic

* Update generated files

* Define metricsets in disabler

* Prepare docker image for ActiveMQ

* Define jolokia endpoint in disabler

* Convert to lightweight module

* Remove downloaded installation bundle

* Fill sample data.json

* Refactor metricset fields

* Update docs

* Fix: do not expose ActiveMQ port

* Fix: mage fmt update

* Dockerfile: define healthcheck

* Move module contents to x-pack

* Fix: move docker-compose definition to x-pack

* Add basic system test

* Fix: update docs

* System tests: topic metrics collected

* Fix: mage fmt update

* System tests: queue, topic metrics collected

* Update docs

* Fix: use compose_host

* Assert that fields are documented

* Fix: typo in metricbeat/docs/modules/activemq.asciidoc

Co-Authored-By: kaiyan-sheng <kaiyan.sheng@elastic.co>

* Add CHANGELOG.next entry

* Fix: mage fmt update
@mtojek
Fix: import stomp in the function scope (elastic#14703)
80b20e2
@mtojek
Fix: use metrics_path instead of path in system tests (elastic#14690)
b26ba77
@mtojek
[Metricbeat] Create Kibana dashboards for ActiveMQ module (elastic#14655
f557fb8 
)

* Kibana dashboard: ActiveMQ broker overview

* Fix: mage fmt update

* Fix: invalid dashboard JSON

* Kibana dashboard: ActiveMQ queues and topics overview

* Add dashboard screenshots

* Enable time units, pct in dashboards
Adjust PR reference in CHANGELOG.next
b32373e
Fix: mage fmt update
0e7a61f
@mtojek mtojek requested a review from a team as a code owner November 26, 2019 15:04
@mtojek mtojek changed the title [7.x][Backport] Add kibana home tutorial for ActiveMQ meatricbeat module [7.x][Backport] create ActiveMQ Metricbeat module Nov 26, 2019
@mtojek mtojek mentioned this pull request Nov 26, 2019
Merged
@mtojek mtojek self-assigned this Nov 26, 2019
@mtojek mtojek added Team:Integrations Label for the Integrations team backport review labels Nov 26, 2019
@mtojek
Copy link
Contributor Author

mtojek commented Nov 26, 2019

Will close in favor of #14788

@mtojek mtojek closed this Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mtojek mtojek

Labels
backport review Team:Integrations Label for the Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mtojek