[Filebeat] Create ActiveMQ module #14840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtojek
added
module
in progress
This comment has been minimized.
This comment has been minimized.
|
jenkins, test this please |
mtojek
changed the title
mtojek
force-pushed
the
14744-create-filebeat-module
branch
2 times, most recently
from
d4d1767
to
e7f3a21
Compare
|
Verified that issues reported by Travis CI are not related. Rebased against master. Here is another PR failing similarly: https://travis-ci.org/elastic/beats/builds/618182978?utm_source=github_status&utm_medium=notification . Most likely there is regretion introduced. |
mtojek
changed the title
mtojek
force-pushed
the
14744-create-filebeat-module
branch
3 times, most recently
from
7c0a62d
to
dd6096e
Compare
Codecov Report
@@ Coverage Diff @@
## master #14840 +/- ##
==========================================
+ Coverage 58.71% 58.73% +0.02%
==========================================
Files 545 545
Lines 34754 34754
==========================================
+ Hits 20406 20413 +7
+ Misses 12440 12432 -8
- Partials 1908 1909 +1
Continue to review full report at Codecov.
|
added 9 commits
November 29, 2019 08:25
mtojek
force-pushed
the
14744-create-filebeat-module
branch
from
dd6096e
to
a32eb07
Compare
|
I reckon that errors reported for "upgrade from an older release" are irrelevant. |
|
jenkins, test this please |
ChrsMark
reviewed
Nov 29, 2019
added 2 commits
November 29, 2019 13:32
ChrsMark
approved these changes
Nov 29, 2019
jsoriano
requested changes
Nov 29, 2019
x-pack/filebeat/module/activemq/audit/test/audit.log-expected.json
Outdated
Show resolved
Hide resolved
mtojek
force-pushed
the
14744-create-filebeat-module
branch
from
a913484
to
2863313
Compare
|
I renamed |
mtojek
added
v7.6.0
and removed
needs_backport
mtojek
added a commit
to mtojek/beats
that referenced
this pull request
Dec 3, 2019
* Enable audit logs in ActiveMQ module * Generate module stub * Update configuration * Add log files * Add sample exception to ActiveMQ log * Define ingest pipeline for ActiveMQ audit logs * Define ingest pipeline for ActiveMQ logs * Adjust ingest pipelines, bugfixing * Do not check timestamp for audit logs * Refactor fields * Fix: mage fmt update * Adjust fields after review * Rename action to message to properly present logs in Kibana * Refactor fields according to the review (cherry picked from commit d4a6086) Rename
mtojek
added a commit
that referenced
this pull request
Dec 3, 2019
* [Filebeat] Create ActiveMQ module (#14840) * Enable audit logs in ActiveMQ module * Generate module stub * Update configuration * Add log files * Add sample exception to ActiveMQ log * Define ingest pipeline for ActiveMQ audit logs * Define ingest pipeline for ActiveMQ logs * Adjust ingest pipelines, bugfixing * Do not check timestamp for audit logs * Refactor fields * Fix: mage fmt update * Adjust fields after review * Rename action to message to properly present logs in Kibana * Refactor fields according to the review (cherry picked from commit d4a6086) Rename * Update CHANGELOG
|
Tested module manually full stack (including dashboards) and works as expected. |
ChrsMark
added
test-plan-ok
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the Filebeat module for the ActiveMQ platform. It supports two kinds of log entries - standard and audit logs.
Master issue: #14744