Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[metricbeat]Docker: add size flag to docker.container #15224

Merged
merged 4 commits into from
Jan 3, 2020
Merged

[metricbeat]Docker: add size flag to docker.container #15224

merged 4 commits into from
Jan 3, 2020

Conversation

odacremolbap
Copy link
Contributor

Solves #14979

Docker container metricset is not retrieving size info.

Testing instructions:

  • create a docker container
  • configura metricbeat enabling docker.container
  • make sure docker.container.size.root_fs and docker.container.size.rw are non 0 values

@odacremolbap odacremolbap requested a review from a team as a code owner December 19, 2019 18:02
@odacremolbap odacremolbap added Team:Integrations Label for the Integrations team Metricbeat Metricbeat containers Related to containers use case bug needs_backport PR is waiting to be backported to other branches. labels Dec 19, 2019
kaiyan-sheng
kaiyan-sheng reviewed Dec 19, 2019
View reviewed changes
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also update docker/container/_meta/data.json pelase?

@odacremolbap
Copy link
Contributor Author

Could you also update docker/container/_meta/data.json pelase?

thanks,
data.json updated

@odacremolbap odacremolbap requested a review from a team December 24, 2019 08:27
@odacremolbap odacremolbap merged commit f40055e into elastic:master Jan 3, 2020
@odacremolbap odacremolbap deleted the fix/docker-size-flag branch January 3, 2020 11:54
odacremolbap pushed a commit to odacremolbap/beats that referenced this pull request Jan 3, 2020
@odacremolbap
[metricbeat]Docker: add size flag to docker.container (elastic#15224)
ce24f81 
* add size flag to docker.container

(cherry picked from commit f40055e)
@odacremolbap odacremolbap mentioned this pull request Jan 3, 2020
Merged
@odacremolbap odacremolbap added v7.6.0 and removed needs_backport PR is waiting to be backported to other branches. labels Jan 3, 2020
@odacremolbap odacremolbap mentioned this pull request Jan 3, 2020
Merged
odacremolbap pushed a commit to odacremolbap/beats that referenced this pull request Jan 3, 2020
@odacremolbap
[metricbeat]Docker: add size flag to docker.container (elastic#15224)
ebcb80e 
* add size flag to docker.container

(cherry picked from commit f40055e)
odacremolbap pushed a commit that referenced this pull request Jan 3, 2020
Cherry-pick #15224 to 7.5: [metricbeat]Docker: add size flag to docke…
42749d4 
…r.container (#15318)

* [metricbeat]Docker: add size flag to docker.container (#15224)
odacremolbap pushed a commit that referenced this pull request Jan 3, 2020
[metricbeat]Docker: add size flag to docker.container (#15224) (#15317)
ee7a15c 
* add size flag to docker.container

(cherry picked from commit f40055e)
@mtojek mtojek mentioned this pull request Feb 26, 2020
Merged
mtojek pushed a commit to mtojek/beats that referenced this pull request Feb 26, 2020
Revert "[metricbeat]Docker: add size flag to docker.container (elasti…
2522bca 
…c#15224)"

This reverts commit f40055e.
mtojek added a commit that referenced this pull request Feb 26, 2020
@mtojek
Revert "[metricbeat]Docker: add size flag to docker.container (#15224)…
e3a9d83 
…" (#16600)

* Revert "[metricbeat]Docker: add size flag to docker.container (#15224)"

This reverts commit f40055e.
mtojek added a commit to mtojek/beats that referenced this pull request Feb 26, 2020
@mtojek
Revert "[metricbeat]Docker: add size flag to docker.container (elasti…
9f68d6c 
…c#15224)" (elastic#16600)

* Revert "[metricbeat]Docker: add size flag to docker.container (elastic#15224)"

This reverts commit f40055e.

(cherry picked from commit e3a9d83)
@mtojek mtojek mentioned this pull request Feb 26, 2020
Merged
mtojek added a commit to mtojek/beats that referenced this pull request Feb 26, 2020
@mtojek
Revert "[metricbeat]Docker: add size flag to docker.container (elasti…
5ed3116 
…c#15224)" (elastic#16600)

* Revert "[metricbeat]Docker: add size flag to docker.container (elastic#15224)"

This reverts commit f40055e.

(cherry picked from commit e3a9d83)
@mtojek mtojek mentioned this pull request Feb 26, 2020
Merged
mtojek added a commit to mtojek/beats that referenced this pull request Feb 26, 2020
@mtojek
Revert "[metricbeat]Docker: add size flag to docker.container (elasti…
da94921 
…c#15224)" (elastic#16600)

* Revert "[metricbeat]Docker: add size flag to docker.container (elastic#15224)"

This reverts commit f40055e.

(cherry picked from commit e3a9d83)
@mtojek mtojek mentioned this pull request Feb 26, 2020
Closed
mtojek added a commit that referenced this pull request Feb 26, 2020
@mtojek
Cherry-pick #16600 to 7.6: Revert "[metricbeat]Docker: add size flag …
457494c 
…to docker.container (#15224)" (#16619)

* Revert "[metricbeat]Docker: add size flag to docker.container (#15224)"
mtojek added a commit that referenced this pull request Feb 26, 2020
@mtojek
Cherry-pick #16600 to 7.x: Revert "[metricbeat]Docker: add size flag …
24c4c6a 
…to docker.container (#15224)" (#16617)

* Revert "[metricbeat]Docker: add size flag to docker.container (#15224)" (#16600)
@eedugon eedugon mentioned this pull request Mar 25, 2020
Closed
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
Cherry-pick elastic#15224 to 7.5: [metricbeat]Docker: add size flag t…
ac2c782 
…o docker.container (elastic#15318)

* [metricbeat]Docker: add size flag to docker.container (elastic#15224)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

Assignees
No one assigned
Labels
bug containers Related to containers use case Metricbeat Metricbeat review Team:Integrations Label for the Integrations team v7.5.2 v7.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@odacremolbap @kaiyan-sheng