Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[metricbeat]Docker: add size flag to docker.container (#15224)" #16600

Merged
merged 2 commits into from
Feb 26, 2020

Conversation

mtojek
Copy link
Contributor

@mtojek mtojek commented Feb 26, 2020

This PR reverts changes introduced in #15224 due to an issue with hanging API call to /containers/json?size=1 for some docker versions.

original issue: #14979
original PR: #15224

@mtojek mtojek requested a review from a team February 26, 2020 13:10
@mtojek mtojek self-assigned this Feb 26, 2020
Copy link
Contributor

@exekias exekias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will need a changelog

@exekias exekias added needs_backport PR is waiting to be backported to other branches. v7.6.1 labels Feb 26, 2020
@mtojek
Copy link
Contributor Author

mtojek commented Feb 26, 2020

this will need a changelog

Updated (CHANGELOG.next.asciidoc)!

@mtojek mtojek merged commit e3a9d83 into elastic:master Feb 26, 2020
mtojek added a commit to mtojek/beats that referenced this pull request Feb 26, 2020
…c#15224)" (elastic#16600)

* Revert "[metricbeat]Docker: add size flag to docker.container (elastic#15224)"

This reverts commit f40055e.

(cherry picked from commit e3a9d83)
@mtojek mtojek added v7.7.0 and removed needs_backport PR is waiting to be backported to other branches. labels Feb 26, 2020
mtojek added a commit to mtojek/beats that referenced this pull request Feb 26, 2020
…c#15224)" (elastic#16600)

* Revert "[metricbeat]Docker: add size flag to docker.container (elastic#15224)"

This reverts commit f40055e.

(cherry picked from commit e3a9d83)
@mtojek mtojek added the v7.6.0 label Feb 26, 2020
mtojek added a commit to mtojek/beats that referenced this pull request Feb 26, 2020
…c#15224)" (elastic#16600)

* Revert "[metricbeat]Docker: add size flag to docker.container (elastic#15224)"

This reverts commit f40055e.

(cherry picked from commit e3a9d83)
@mtojek mtojek added the v7.5.0 label Feb 26, 2020
mtojek added a commit that referenced this pull request Feb 26, 2020
…to docker.container (#15224)" (#16619)

* Revert "[metricbeat]Docker: add size flag to docker.container (#15224)"
mtojek added a commit that referenced this pull request Feb 26, 2020
…to docker.container (#15224)" (#16617)

* Revert "[metricbeat]Docker: add size flag to docker.container (#15224)" (#16600)
@nyetwurk
Copy link

nyetwurk commented Aug 17, 2022

Please reopen #14979. Why was this merged with no documentation of a regression?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants