-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "[metricbeat]Docker: add size flag to docker.container (#15224)" #16600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtojek
force-pushed
the
14979-revert-size-flag
branch
from
February 26, 2020 13:12
fe81d75
to
e58dde5
Compare
mtojek
force-pushed
the
14979-revert-size-flag
branch
from
February 26, 2020 13:12
e58dde5
to
2522bca
Compare
exekias
approved these changes
Feb 26, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will need a changelog
exekias
added
needs_backport
PR is waiting to be backported to other branches.
v7.6.1
labels
Feb 26, 2020
Updated (CHANGELOG.next.asciidoc)! |
exekias
approved these changes
Feb 26, 2020
mtojek
added a commit
to mtojek/beats
that referenced
this pull request
Feb 26, 2020
…c#15224)" (elastic#16600) * Revert "[metricbeat]Docker: add size flag to docker.container (elastic#15224)" This reverts commit f40055e. (cherry picked from commit e3a9d83)
mtojek
added
v7.7.0
and removed
needs_backport
PR is waiting to be backported to other branches.
labels
Feb 26, 2020
mtojek
added a commit
to mtojek/beats
that referenced
this pull request
Feb 26, 2020
…c#15224)" (elastic#16600) * Revert "[metricbeat]Docker: add size flag to docker.container (elastic#15224)" This reverts commit f40055e. (cherry picked from commit e3a9d83)
mtojek
added a commit
to mtojek/beats
that referenced
this pull request
Feb 26, 2020
…c#15224)" (elastic#16600) * Revert "[metricbeat]Docker: add size flag to docker.container (elastic#15224)" This reverts commit f40055e. (cherry picked from commit e3a9d83)
Please reopen #14979. Why was this merged with no documentation of a regression? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts changes introduced in #15224 due to an issue with hanging API call to
/containers/json?size=1
for some docker versions.original issue: #14979
original PR: #15224