Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding integration test for kibana Metricbeat module, xpack code path #15965

Merged
merged 4 commits into from
Feb 13, 2020
Merged

Adding integration test for kibana Metricbeat module, xpack code path #15965

merged 4 commits into from
Feb 13, 2020

Conversation

ycombinator
Copy link
Contributor

@ycombinator ycombinator commented Jan 30, 2020 •
edited
Loading

What does this PR do?

This PR adds an integration test for the Metricbeat kibana module when xpack.enabled: true is set in the module configuration.

Why is it important?

The code path in the kibana module when xpack.enabled was set to true was previously not being exercised by integration tests. Moreover, it's a critical code path as it powers the Stack Monitoring feature.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works

Related issues

@ycombinator ycombinator added Metricbeat Metricbeat Feature:Stack Monitoring Team:Integrations Label for the Integrations team labels Jan 30, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/stack-monitoring (Stack monitoring)

@ycombinator ycombinator added module needs_backport PR is waiting to be backported to other branches. v7.7.0 v8.0.0 labels Jan 30, 2020
@ycombinator ycombinator marked this pull request as ready for review January 30, 2020 20:51
@ycombinator ycombinator requested a review from a team as a code owner January 30, 2020 20:51
@ycombinator ycombinator changed the title Adding integration test for kibana MB module, xpack code path Adding integration test for kibana Metricbeat module, xpack code path Jan 30, 2020
@ycombinator
Copy link
Contributor Author

jenkins, test this

@ycombinator
Copy link
Contributor Author

jenkins, test this

@ycombinator ycombinator requested a review from a team February 5, 2020 01:07
@ycombinator
Copy link
Contributor Author

jenkins, test this

ChrsMark
ChrsMark approved these changes Feb 11, 2020
View reviewed changes
Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm, if CI is happy too

@ycombinator
Copy link
Contributor Author

Travis CI is green and Jenkins CI failures are unrelated. Merging.

@ycombinator ycombinator merged commit 4795676 into elastic:master Feb 13, 2020
@ycombinator ycombinator deleted the mb-kb-xp-int-test branch February 13, 2020 16:05
@ycombinator ycombinator removed the needs_backport PR is waiting to be backported to other branches. label Feb 13, 2020
@zube zube bot added [zube]: Done needs_backport PR is waiting to be backported to other branches. and removed [zube]: In Review labels Feb 13, 2020
@ycombinator ycombinator mentioned this pull request Feb 13, 2020
Merged
@ycombinator ycombinator removed the needs_backport PR is waiting to be backported to other branches. label Feb 13, 2020
ycombinator added a commit to ycombinator/beats that referenced this pull request Feb 19, 2020
@ycombinator
Adding integration test for kibana Metricbeat module, xpack code path (…
76d49b5 
…elastic#15965)

* Adding integration test for kibana MB module, xpack code path

* Fixing imports formatting

* Adding missing import

* Replace assert.* with require.*
ycombinator added a commit that referenced this pull request Feb 19, 2020
@ycombinator
Adding integration test for kibana Metricbeat module, xpack code path (…
83b0fd4 
…#15965) (#16309)

* Adding integration test for kibana MB module, xpack code path

* Fixing imports formatting

* Adding missing import

* Replace assert.* with require.*
kvch pushed a commit to kvch/beats that referenced this pull request Feb 20, 2020
@ycombinator @kvch
Adding integration test for kibana Metricbeat module, xpack code path (…
7a3784e 
…elastic#15965)

* Adding integration test for kibana MB module, xpack code path

* Fixing imports formatting

* Adding missing import

* Replace assert.* with require.*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrsMark ChrsMark ChrsMark approved these changes

Assignees
No one assigned
Labels
Feature:Stack Monitoring Metricbeat Metricbeat module Team:Integrations Label for the Integrations team v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ycombinator @elasticmachine @ChrsMark @andresrc