Adding integration test for logstash Metricbeat module, xpack code path #15800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jan 24, 2020
ycombinator
added
:Testing
Metricbeat
|
Pinging @elastic/stack-monitoring (Stack monitoring) |
ycombinator
added
review
Team:Beats
v7.7.0
v8.0.0
needs_backport
mtojek
approved these changes
Jan 24, 2020
|
Blocked on #15819. |
andresrc
added
[zube]: Inbox
[zube]: In Review
and removed
[zube]: In Review
[zube]: Inbox
labels
ycombinator
force-pushed
the
mb-ls-xp-int-test
branch
from
54a13e1
to
e0546bb
Compare
3 tasks
ycombinator
changed the title
3 tasks
|
Travis CI is green and Jenkins CI failures are unrelated. Merging. |
ycombinator
added a commit
to ycombinator/beats
that referenced
this pull request
Jan 30, 2020
…th (elastic#15800) * Adding integration test for logstash module, xpack data path * Adding godoc * Refactoring * More refactoring * Fixing reference
ycombinator
removed
the
needs_backport
3 tasks
ycombinator
added a commit
to ycombinator/beats
that referenced
this pull request
Apr 8, 2020
…th (elastic#15800) * Adding integration test for logstash module, xpack data path * Adding godoc * Refactoring * More refactoring * Fixing reference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
logstashmodule whenxpack.enabled: trueis set in the module configuration,NewReportingMetricSetV2ErrorsandNewMetricSets, in order to make the above test possible, andlogstashintegration test code.